Skip to content

Conversation

@corneadoug
Copy link
Contributor

What is this PR for?

Following the PR #714 and its comments, we are moving the download data outside the paragraph settings. Which would allow a possible drop down to choose backend data download in the future.

What type of PR is it?

Improvement

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-975

How should this be tested?

Show a %Table type of result (you can use below code in a paragraph for that).
You should see the icon, click on it to download the data.

print(s"""%table
name\tsize
sun\t127.6
moon\t0.6458
gerard\t45.234856803""")

Screenshots (if appropriate)

screen shot 2016-06-08 at 4 15 22 pm

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No, but maybe feature announcement during release

@corneadoug
Copy link
Contributor Author

CI fail not related:

Failed tests: 
  SparkParagraphIT.testSqlSpark:162 Paragraph from SparkParagraphIT of testSqlSpark status: 
Expected: "FINISHED"
     but: was "ERROR"
  SparkParagraphIT.testSqlSpark:169 Paragraph from SparkParagraphIT of testSqlSpark result: 
Expected: "age\njob\nmarital\neducation\nbalance\n30 unemployed married primary 1,787\nage\njob\nmarital\neducation\nbalance"
     but: was "Table not found: bank; line 1 pos 14\nset zeppelin.spark.sql.stacktrace = true to see full stacktrace"

@corneadoug corneadoug closed this Jun 9, 2016
@corneadoug corneadoug reopened this Jun 9, 2016
@corneadoug
Copy link
Contributor Author

Merging if there is no more discussion

@asfgit asfgit closed this in 548fa2b Jun 10, 2016
@corneadoug corneadoug deleted the improve/downloadDataBtnVisibility branch August 24, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant