filtering subdirectory names. #964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2016 23:48
Member
|
Looks good to me +1 |
| return notebook; | ||
| } | ||
|
|
||
| if(notebook.children) { |
Contributor
Author
There was a problem hiding this comment.
oh I see. thank you for your comment @felixcheung
| <li><a href="" data-toggle="modal" data-target="#noteNameModal"><i class="fa fa-plus"></i> Create new note</a></li> | ||
| <li class="divider"></li> | ||
| <div id="notebook-list" class="scrollbar-container"> | ||
| <li class="filter-names" ng-include="'components/filterNoteNames/filter-note-names.html'"></li> |
Contributor
There was a problem hiding this comment.
We should make keep that line, and modify filter-note-names.html to have ng-model="$parent.query"
Contributor
|
@astroshim Tested, works well, except for those 2 comments LGTM. The code handling those notebook lists and their filtering became quite messy and error prone. |
Contributor
Author
|
@corneadoug Thank you for your review. |
Contributor
Author
|
@corneadoug I refactored the codes that you pointed out. please review. |
Contributor
|
Tested, Merging if no more discussions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
It needs to filtering subdirectory names in navbar.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-886
How should this be tested?
try filter the note name on navbar.
Screenshots (if appropriate)
Questions: