[ZEPPELIN-952] Refine website style #962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@minahlee Nice work! Definitely it looks much better than before 👍 |
Member
|
👍 looks great to me! |
Member
|
Looks good to me! |
Member
|
Nice, LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jun 6, 2016
…er.md ### What is this PR for? Currently some code blocks in [docs/development/writingzeppelininterpreter.html](https://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/development/writingzeppelininterpreter.html) & [docs/storage/storage.html#S3](https://zeppelin.apache.org/docs/0.6.0-SNAPSHOT/storage/storage.html) are broken. But it seems the broken code block in `docs/storage/storage.html` is already handled in #962. So I just updated in `docs/development/writingzeppelininterpreter.html` ### What type of PR is it? Hot Fix ### Todos ### What is the Jira issue? [ZEPPELIN-959](https://issues.apache.org/jira/browse/ZEPPELIN-959) ### How should this be tested? See the attached images :) ### Screenshots (if appropriate) - Before  - After <img width="1077" alt="screen shot 2016-06-05 at 7 38 50 pm" src="https://cloud.githubusercontent.com/assets/10060731/15812563/4b36e696-2b6b-11e6-8f14-f4572331eec6.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes #969 from AhyoungRyu/ZEPPELIN-959 and squashes the following commits: 8f8cc70 [AhyoungRyu] ZEPPELIN-959: Fix odd code block in writingzeppelininterpreter.md 879b8f9 [AhyoungRyu] Revert "ZEPPELIN-959: Fix odd code blocks in some documentations" 967b2fa [AhyoungRyu] ZEPPELIN-959: Fix odd code blocks in some documentations
Member
Author
|
Merge if there is no more discussion |
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2016
### What is this PR for? Apply same style in website main page as #962 ### What type of PR is it? Documentation ### What is the Jira issue? [ZEPPELIN-952](https://issues.apache.org/jira/browse/ZEPPELIN-952) ### Screenshots (if appropriate) **Before** <img width="1184" alt="screen shot 2016-06-04 at 10 17 34 pm" src="https://cloud.githubusercontent.com/assets/8503346/15803735/32142684-2aa2-11e6-9b9e-b4db1673f2fd.png"> **After** <img width="1184" alt="screen shot 2016-06-04 at 10 17 23 pm" src="https://cloud.githubusercontent.com/assets/8503346/15803734/2f0771e4-2aa2-11e6-888a-d2d0852bb92a.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Mina Lee <minalee@nflabs.com> Closes #963 from minahlee/gh-page/ZEPPELIN-952 and squashes the following commits: f862dac [Mina Lee] prettify document 5f7e885 [Mina Lee] remove incubating from mailing list url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
Documentation
What is the Jira issue?
ZEPPELIN-952
Screenshots (if appropriate)
Before
After
Before
After
Before
After
Before
After
Questions: