[ZEPPELIN-939] Improve notebook authorization documentation #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
changed the title
| The interpret method takes the user string as parameter and executes the jdbc call using a connection in the user's connection pool. | ||
|
|
||
| In case of Presto, we don't need password if the Presto DB server runs backend code using HDFS authorization for the user. | ||
| For databases like Vertica and Mysql we have to store password information for users. |
Member
There was a problem hiding this comment.
I agree we should fine tune this description, but is it more confusing that it is absent?
Contributor
Author
There was a problem hiding this comment.
@felixcheung Thanks for sharing your opinion. Yeah you're right. I also saw some informations is added in this docs at #860. So I'll revert this docs then.
Contributor
Author
|
@felixcheung I put |
| <center><img src="../assets/themes/zeppelin/img/docs-img/permission_setting.png"></center> | ||
|
|
||
| Fill out the each forms with comma seperated **users** and **groups** configured in `conf/shiro.ini` file. | ||
| If the form is empty (*), it means that any users can perform that operation. |
Contributor
Author
There was a problem hiding this comment.
@felixcheung The default value is set as *. It means a user left the text box empty.
Here is the default status of the notebook permission setting. As you can see in the placeholder :
Member
|
minor question, looks good |
Member
|
LGTM |
Contributor
|
No problem of rendering with the new "theme" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently Zeppelin provides authorization mechanism on each notebooks. But it seems many users can not get much useful information through the existing notebook authorization docs. So I add some information so that users can follow step by step.
Moreover, interpreter authorization docs doesn't provide much information so far. This can be confused to users. So I removed it temporally. We can add it again when we have specific(?) feature for
interpreter & data source authorization.What type of PR is it?
Improvement | Documentation
Todos
What is the Jira issue?
ZEPPELIN-939
How should this be tested?
Screenshots (if appropriate)
Questions: