Hotfix - does not working notebook filter on navibar.

[astroshim]

What is this PR for?

It doesn't working the notebook filter on navibar.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-873

Screenshots (if appropriate)

• before
  
• after
  

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[minahlee]

@astroshim Seems like folder structure notebook is broken. Could you take a look?

Attaching screenshot
Master

PR#912

[astroshim]

@minahlee Thank you for review and finding the problem. I'll take a look this.

[astroshim]

@minahlee I fixed the problem. Can you review?

[bzz]

CI failure is not related and is due to spark download failure :\

Could you plz create a JIRA issue for that with label flaky-build ?

[astroshim]

@bzz Okay. I'll make one.

[astroshim]

@bzz I couldn't find the reason of build failure so I just retrigger CI.

[minahlee]

@astroshim Thanks for the contribution. One feedback from me is that it would be awesome if we can filter subdirectory names in nav bar like main page does:

This PR only can filter top-level directory name, so if user types b it won't show 0/b/c notebook.
We can leave it as a future work if it is too much.

[astroshim]

@minahlee Yes, you're right. It would be better supporting the filter subdirectory names.
How about creating new PR for filtering subdirectory names?

[minahlee]

@astroshim sounds good :)
merging if there is no more discussion

[bzz]

Looks good to me.
@astroshim can you please post the link to JIRA issue here as well?

Last failure seems very similar to #917

  ZeppelinIT.testSparkInterpreterDependencyLoading:209 » ElementNotVisible Eleme...

[astroshim]

@bzz I made issue(https://issues.apache.org/jira/browse/ZEPPELIN-886).

[bzz]

@astroshim thanks! I think there might be a fix for CI just merged to master - could you please rebase this branch and see if that resolves the issue?

Otherwise looks great to me!

[astroshim]

@bzz I rebased.

[bzz]

That CI issue is gone, current failure is due to networking issues on Spark download =\

Shall be good to merge.

[minahlee]

@astroshim Did you remove tutorial notebook on purpose? If not, can you revert the last commit?

[astroshim]

@minahlee It's my mistake. I reverted.