Skip to content

Conversation

@prabhjyotsingh
Copy link
Contributor

What is this PR for?

After #761, on compiling project this file karma.conf.js started showing diff.

What type of PR is it?

[Hot Fix]

Todos

  • - Add karma.conf.js with diff.

What is the Jira issue?

N/A

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo
Copy link
Member

LGTM

@prabhjyotsingh
Copy link
Contributor Author

Merging is no more discussion.

@asfgit asfgit closed this in 1ba0f55 May 9, 2016
onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
### What is this PR for?
After apache#761, on compiling project this file `karma.conf.js` started showing diff.

### What type of PR is it?
[Hot Fix]

### Todos
* [x] - Add karma.conf.js with diff.

### What is the Jira issue?
N/A

### How should this be tested?

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Prabhjyot Singh <[email protected]>

Closes apache#875 from prabhjyotsingh/datatables_missing_karam_conf and squashes the following commits:

f313878 [Prabhjyot Singh] add missing karma.conf.js
@prabhjyotsingh prabhjyotsingh deleted the datatables_missing_karam_conf branch June 1, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants