[ZEPPELIN-705]Search should aware notebook permission

[rranjan03]

What is this PR for?

Make search aware of notebook permissions and allow only those search results for which user has read permission.

What type of PR is it?

Bug Fix

Todos

NA

What is the Jira issue?

ZEPPELIN-705

How should this be tested?

Screenshots (if appropriate)

Questions:

• Does the licenses files need update?No
• Is there breaking changes for older versions?No
• Does this needs documentation?No

[Leemoonsoo]

@ravicodder
Thanks for the patch. Would it be difficult to make corresponding rest api test?

[prabhjyotsingh]

LGTM, +1 for adding test.

[rranjan03]

@Leemoonsoo @prabhjyotsingh Sorry for late response. Added test . Please have a look.

[Leemoonsoo]

@ravicodder No worries. Thanks for the fix and tests. Looks good to me.

[bzz]

@ravicodder thank you for fixing it.

Could you also please make sure that coded formatting is consistent project's style guide?

👍 for having tests! Right now testSearch is bit long though, would you be willing to extract some methods to make it a bit more readable?

[rranjan03]

@bzz Thanks for the review,
I have tried to make test more readable. Please have a look.

[Leemoonsoo]

LGTM

[bzz]

Looks great, thank you for taking care.

I have one more question: in case of no auth configured, can somebody please help me to understand what is the performance implication or price per-API call to /serach/, that is added by this changeset?

We want search to be as fast as possible in a common case, so just want to make sure that we keep an eye on it. Would that be reasonable to add something like this to the query API code and at least manually compare results once (post here), to make sure preformance does not degraded, or see if any optimization are needed for case when no auth is configuted?

Please let me know what do you think!

[rranjan03]

@bzz
At a time we have set the search results to show at most 20 results. I feel, for such a small value there should not be any performance issues.

I noted the time to search in both the cases, with permission check and without permission check.
From manual test, We can see there is no performance degradation.

[bzz]

@ravicodder looks great, thank you for double-checking!
Merging if there is no more discussion