-
Notifications
You must be signed in to change notification settings - Fork 2.8k
increase implicitlyWait for WebDriver #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
prabhjyotsingh
wants to merge
3
commits into
apache:master
from
prabhjyotsingh:increaseImplicitlyWait
Closed
increase implicitlyWait for WebDriver #785
prabhjyotsingh
wants to merge
3
commits into
apache:master
from
prabhjyotsingh:increaseImplicitlyWait
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
change assertTrue to waitForParagraph(1, "FINISHED");
2a51a1f to
5c36fac
Compare
Contributor
Author
|
This seems to fix PR #783 |
Member
|
LGTM |
Contributor
Author
|
Merge this ? |
Member
|
I'm merging it into the master. |
prabhjyotsingh
added a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Mar 23, 2016
### What is this PR for? This is with respect to travis build failure on `sendKeys`. An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance. #### Update Travis mostly fails on `sendKeys`; hence, change the way text is sent to paragraph. ### What type of PR is it? Hot Fix ### What is the Jira issue? N/A ### How should this be tested? CI should be green. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Prabhjyot Singh <[email protected]> Closes apache#785 from prabhjyotsingh/increaseImplicitlyWait and squashes the following commits: 5c36fac [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED"); 0249b49 [Prabhjyot Singh] replace sendkeys with javascript function 734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? This is with respect to travis build failure on `sendKeys`. An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance. #### Update Travis mostly fails on `sendKeys`; hence, change the way text is sent to paragraph. ### What type of PR is it? Hot Fix ### What is the Jira issue? N/A ### How should this be tested? CI should be green. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Prabhjyot Singh <[email protected]> Closes apache#785 from prabhjyotsingh/increaseImplicitlyWait and squashes the following commits: 5c36fac [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED"); 0249b49 [Prabhjyot Singh] replace sendkeys with javascript function 734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is with respect to travis build failure on
sendKeys.An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance.
Update
Travis mostly fails on
sendKeys; hence, change the way text is sent to paragraph.What type of PR is it?
Hot Fix
What is the Jira issue?
N/A
How should this be tested?
CI should be green.
Screenshots (if appropriate)
Questions: