Skip to content

Conversation

@prabhjyotsingh
Copy link
Contributor

What is this PR for?

This is with respect to travis build failure on sendKeys.

An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance.

Update

Travis mostly fails on sendKeys; hence, change the way text is sent to paragraph.

What type of PR is it?

Hot Fix

What is the Jira issue?

N/A

How should this be tested?

CI should be green.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

change assertTrue to waitForParagraph(1, "FINISHED");
@prabhjyotsingh prabhjyotsingh force-pushed the increaseImplicitlyWait branch from 2a51a1f to 5c36fac Compare March 19, 2016 04:23
@prabhjyotsingh
Copy link
Contributor Author

This seems to fix PR #783

@Leemoonsoo
Copy link
Member

LGTM

@prabhjyotsingh
Copy link
Contributor Author

Merge this ?

@Leemoonsoo
Copy link
Member

I'm merging it into the master.

@asfgit asfgit closed this in d195757 Mar 23, 2016
prabhjyotsingh added a commit to prabhjyotsingh/zeppelin that referenced this pull request Mar 23, 2016
### What is this PR for?
This is with respect to travis build failure on `sendKeys`.

An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance.

#### Update
Travis mostly fails on `sendKeys`; hence, change the way text is sent to paragraph.

### What type of PR is it?
Hot Fix

### What is the Jira issue?
N/A

### How should this be tested?
CI should be green.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Prabhjyot Singh <[email protected]>

Closes apache#785 from prabhjyotsingh/increaseImplicitlyWait and squashes the following commits:

5c36fac [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED");
0249b49 [Prabhjyot Singh] replace sendkeys with javascript function
734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
onkarshedge pushed a commit to onkarshedge/incubator-zeppelin that referenced this pull request May 11, 2016
### What is this PR for?
This is with respect to travis build failure on `sendKeys`.

An implicit wait is to tell WebDriver to poll the DOM for a certain amount of time when trying to find an element or elements if they are not immediately available. The default setting is 0. Once set, the implicit wait is set for the life of the WebDriver object instance.

#### Update
Travis mostly fails on `sendKeys`; hence, change the way text is sent to paragraph.

### What type of PR is it?
Hot Fix

### What is the Jira issue?
N/A

### How should this be tested?
CI should be green.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Prabhjyot Singh <[email protected]>

Closes apache#785 from prabhjyotsingh/increaseImplicitlyWait and squashes the following commits:

5c36fac [Prabhjyot Singh] add waitForParagraph(1, "FINISHED"); change assertTrue to waitForParagraph(1, "FINISHED");
0249b49 [Prabhjyot Singh] replace sendkeys with javascript function
734a901 [Prabhjyot Singh] increase implicitlyWait for WebDriver
@prabhjyotsingh prabhjyotsingh deleted the increaseImplicitlyWait branch June 1, 2016 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants