Fixed typo in resource pool usage. #781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the fix. LGTM |
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import com.google.gson.Gson; | ||
| import com.google.gson.GsonBuilder; |
1 task
Member
|
LGTM |
Member
|
Merge if there're no more discussions |
fireboy1919
added a commit
to fireboy1919/incubator-zeppelin
that referenced
this pull request
Apr 5, 2016
This pull request adds fixes a typo in the resource pool system. Bug Fix * [ ] - Task https://issues.apache.org/jira/browse/ZEPPELIN-749 As this is a refactor only fix, no testing is appropriate. Same as above. * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No. Author: Rusty Phillips <[email protected]> Closes apache#781 from fireboy1919/fix_typo and squashes the following commits: dd04182 [Rusty Phillips] Fixed typo in resource pool usage.
onkarshedge
pushed a commit
to onkarshedge/incubator-zeppelin
that referenced
this pull request
May 11, 2016
### What is this PR for? This pull request adds fixes a typo in the resource pool system. ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-749 ### How should this be tested? As this is a refactor only fix, no testing is appropriate. ### Screenshots (if appropriate) Same as above. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No. Author: Rusty Phillips <[email protected]> Closes apache#781 from fireboy1919/fix_typo and squashes the following commits: dd04182 [Rusty Phillips] Fixed typo in resource pool usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pull request adds fixes a typo in the resource pool system.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-749
How should this be tested?
As this is a refactor only fix, no testing is appropriate.
Screenshots (if appropriate)
Same as above.
Questions:
No
No
No.