Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9351a0d
Committed for Datatables #6
ankur-jain-yash Mar 4, 2016
00b36e5
Reverted line 117 and 2122 as per previous code
ankur-jain-yash Mar 4, 2016
df1620c
Updated testcase as resultant paragraph have text of buttons and sear…
ankur-jain-yash Mar 4, 2016
aea8446
Merge branch 'apache/master'
ankur-jain-yash Mar 14, 2016
6e6587b
Updating codebase as per @prabhjyotsingh comments
ankur-jain-yash Mar 14, 2016
7901f5e
Merge branch 'refs/heads/master' into apache/master
ankur-jain-yash Mar 29, 2016
415c1f5
Merge branch 'apache/master'
ankur-jain-yash Apr 5, 2016
d23202e
Merge remote-tracking branch 'refs/remotes/origin/master' into apache…
ankur-jain-yash Apr 6, 2016
0c94cab
Merge branch 'master' of https://github.com/ankurmitujjain/incubator-…
ankur-jain-yash Apr 6, 2016
6363e97
Merge branch 'master' of https://github.com/ankurmitujjain/incubator-…
ankur-jain-yash Apr 6, 2016
adb66a3
Merge branch 'upstream/master'
ankur-jain-yash Apr 6, 2016
0c5f623
Revert "Merge branch 'upstream/master'"
ankur-jain-yash Apr 6, 2016
0ee76b1
Update 3 files
ankur-jain-yash Apr 6, 2016
80bd58c
Merge branch 'upstream/master'
ankur-jain-yash Apr 6, 2016
210b7a6
Updates latest code of controller
ankur-jain-yash Apr 6, 2016
d3aadc6
Updated testcase
ankur-jain-yash Apr 6, 2016
e4b3abb
Removed R.md accidentally added
ankur-jain-yash Apr 6, 2016
09c87a0
Updated for indent
ankurmitujjain Apr 8, 2016
b23cab4
Updated for indent
ankurmitujjain Apr 8, 2016
38ee3c3
Updated for indent
ankurmitujjain Apr 8, 2016
c9b675d
Updated for indent
ankurmitujjain Apr 8, 2016
2561630
Updated for indent
ankurmitujjain Apr 8, 2016
9c4412f
Remove buttons
corneadoug Apr 12, 2016
5aca081
Last Modifications
corneadoug Apr 12, 2016
dd8901b
last fixes
corneadoug Apr 12, 2016
e6470aa
Merge pull request #1 from corneadoug/clean/dataframe
ankurmitujjain Apr 15, 2016
4ddcc0f
Updated testcases for @corneadoug pull request
ankurmitujjain Apr 18, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions zeppelin-web/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,11 @@ module.exports = function (grunt) {
cwd: '<%= yeoman.app %>',
dest: '<%= yeoman.dist %>',
src: ['app/**/*.html', 'components/**/*.html']
}, {
expand: true,
cwd: 'bower_components/datatables/media/images',
src: '{,*/}*.{png,jpg,jpeg,gif}',
dest: '<%= yeoman.dist %>/images'
}, {
expand: true,
cwd: '.tmp/images',
Expand Down
4 changes: 3 additions & 1 deletion zeppelin-web/bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
"ngtoast": "~2.0.0",
"ng-focus-if": "~1.0.2",
"bootstrap3-dialog": "bootstrap-dialog#~1.34.7",
"floatThead": "~1.3.2"
"floatThead": "~1.3.2",
"datatables.net-bs": "~1.10.11",
"datatables.net-buttons-bs": "~1.1.2"
},
"devDependencies": {
"angular-mocks": "1.5.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
-->
<div
id="p{{paragraph.id}}_resize"
style='padding-bottom: 5px;'
resize='{"allowresize": "{{!asIframe && !viewOnly}}", "graphType": "{{getResultType()}}"}'
resizable on-resize="resizeParagraph(width, height);">
<div ng-include src="'app/notebook/paragraph/paragraph-graph.html'"></div>
Expand Down
47 changes: 31 additions & 16 deletions zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -1260,40 +1260,55 @@ angular.module('zeppelinWebApp')
return '&#'+i.charCodeAt(0)+';';
});
}
html += ' <td>'+formatTableContent(v)+'</td>';
html += ' <td>'+formatTableContent(v)+'</td>';
}
html += ' </tr>';
}
html += ' </tbody>';
html += '</table>';

angular.element('#p' + $scope.paragraph.id + '_table').html(html);
var tableDomEl = angular.element('#p' + $scope.paragraph.id + '_table');
tableDomEl.html(html);
var oTable = tableDomEl.children(1).DataTable({
paging: false,
info: false,
autoWidth: false,
lengthChange: false,
searching: false,
dom: '<>'
});

if ($scope.paragraph.result.msgTable.length > 10000) {
angular.element('#p' + $scope.paragraph.id + '_table').css('overflow', 'scroll');
// set table height
var height = $scope.paragraph.config.graph.height;
angular.element('#p' + $scope.paragraph.id + '_table').css('height', height);
tableDomEl.css({
'overflow': 'scroll',
'height': $scope.paragraph.config.graph.height
});
} else {

var dataTable = angular.element('#p' + $scope.paragraph.id + '_table .table');
dataTable.floatThead({
scrollContainer: function (dataTable) {
return angular.element('#p' + $scope.paragraph.id + '_table');
scrollContainer: function(dataTable) {
return tableDomEl;
}
});
angular.element('#p' + $scope.paragraph.id + '_table .table').on('remove', function () {
angular.element('#p' + $scope.paragraph.id + '_table .table').floatThead('destroy');

dataTable.on('remove', function () {
dataTable.floatThead('destroy');
});

tableDomEl.css({
'position': 'relative',
'height': '100%'
});
tableDomEl.perfectScrollbar('destroy')
.perfectScrollbar({minScrollbarLength: 20});

angular.element('#p' + $scope.paragraph.id + '_table').css('position', 'relative');
angular.element('#p' + $scope.paragraph.id + '_table').css('height', '100%');
angular.element('#p' + $scope.paragraph.id + '_table').perfectScrollbar('destroy');
angular.element('#p' + $scope.paragraph.id + '_table').perfectScrollbar();
angular.element('.ps-scrollbar-y-rail').css('z-index', '1002');

// set table height
var psHeight = $scope.paragraph.config.graph.height;
angular.element('#p' + $scope.paragraph.id + '_table').css('height', psHeight);
angular.element('#p' + $scope.paragraph.id + '_table').perfectScrollbar('update');
tableDomEl.css('height', psHeight);
tableDomEl.perfectScrollbar('update');
}

};
Expand Down
15 changes: 15 additions & 0 deletions zeppelin-web/src/app/notebook/paragraph/paragraph.css
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,21 @@
width: 100%;
}

table.dataTable {
margin-top: 0px !important;
margin-bottom: 6px !important;
}

table.dataTable.table-condensed > thead > tr > th {
padding-right: 28px;
}

table.dataTable.table-condensed .sorting:after,
table.dataTable.table-condensed .sorting_asc:after,
table.dataTable.table-condensed .sorting_desc:after {
right: 12px;
}

.graphContainer {
position: relative;
margin-bottom: 5px;
Expand Down
10 changes: 10 additions & 0 deletions zeppelin-web/src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@
<link rel="stylesheet" href="bower_components/highlightjs/styles/github.css" />
<link rel="stylesheet" href="bower_components/ngtoast/dist/ngToast.css" />
<link rel="stylesheet" href="bower_components/bootstrap3-dialog/dist/css/bootstrap-dialog.min.css" />
<link rel="stylesheet" href="bower_components/datatables.net-bs/css/dataTables.bootstrap.css" />
<link rel="stylesheet" href="bower_components/datatables.net-buttons-bs/css/buttons.bootstrap.css" />
<!-- endbower -->
<link rel="stylesheet" href="bower_components/jquery-ui/themes/base/all.css" />
<!-- endbuild -->
Expand Down Expand Up @@ -131,6 +133,14 @@
<script src="bower_components/bootstrap3-dialog/dist/js/bootstrap-dialog.min.js"></script>
<script src="bower_components/floatThead/dist/jquery.floatThead.js"></script>
<script src="bower_components/floatThead/dist/jquery.floatThead.min.js"></script>
<script src="bower_components/datatables.net/js/jquery.dataTables.js"></script>
<script src="bower_components/datatables.net-bs/js/dataTables.bootstrap.js"></script>
<script src="bower_components/datatables.net-buttons/js/dataTables.buttons.js"></script>
<script src="bower_components/datatables.net-buttons/js/buttons.colVis.js"></script>
<script src="bower_components/datatables.net-buttons/js/buttons.flash.js"></script>
<script src="bower_components/datatables.net-buttons/js/buttons.html5.js"></script>
<script src="bower_components/datatables.net-buttons/js/buttons.print.js"></script>
<script src="bower_components/datatables.net-buttons-bs/js/buttons.bootstrap.js"></script>
<!-- endbower -->
<!-- endbuild -->
<!-- build:js({.tmp,src}) scripts/scripts.js -->
Expand Down