Skip to content

Conversation

@AhyoungRyu
Copy link
Contributor

What is this PR for?

After #672 is merged, a bug was reported by Zeppelin user a few days ago.
That issue was addressed already fixed by #464 and included after release 0.5.6.

So I add some information to docs/manual/publish.md about troubleshooting and style guide mentioned by @doanduyhai at the Zeppelin user mailing thread.

What type of PR is it?

Documentation

Todos

  • - Add troubleshooting information to publish.md

Is there a relevant Jira issue?

Maybe ZEPPELIN-413 & ZEPPELIN-585

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

<link rel="stylesheet" href="zeppelin-web/bower_components/bootstrap/dist/css/bootstrap.css" />
<link rel="stylesheet" href="zeppelin-web/fonts/font-awesome.min.css">
....
</head>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it is required, while paragraph is exported as an iframe. Can some clarify it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested, no need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. @doanduyhai can you explain this ? : )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tested and it doesn't need those lines.

@AhyoungRyu AhyoungRyu closed this Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants