ZEPPELIN-646: Shell interpreter output streaming #683
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
After some search, it seems that the streaming output wasn't documented anywhere. |
Contributor
Author
|
@corneadoug Make sense. Then I'll write a new docs for ability of Zeppelin streaming output. |
Member
|
cool @DarkMaN1 |
Member
|
Yes it would be nice to document how to use InterpreterOutput when writing interpreter. Anyway, LGTM |
Contributor
Author
|
@Leemoonsoo Make sense. Then i'll add that content you mentioned in the docs : ) |
Member
|
Merge if there're no more discussions. |
1 task
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2017
### What is this PR for? Shell interpreter streaming output had been available by #683, but currently it's broken after #1087 merged. This patch is for putting it back. ### What type of PR is it? Bug Fix ### TODO - [x] Fix test ### What is the Jira issue? [ZEPPELIN-1880](https://issues.apache.org/jira/browse/ZEPPELIN-1880) ### How should this be tested? ``` %sh date && sleep 3 && date ``` the each timestamp must be printed as streaming output ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1833 from AhyoungRyu/ZEPPELIN-1880 and squashes the following commits: 8fe33c4 [AhyoungRyu] Fix invalid test cases e2fd4bf [AhyoungRyu] Add test for shell inpt timeout property 34d3021 [AhyoungRyu] Fix shell intp streaming output result
asfgit
pushed a commit
that referenced
this pull request
Jan 24, 2017
### What is this PR for? Shell interpreter streaming output had been available by #683, but currently it's broken after #1087 merged. This patch is for putting it back. ### What type of PR is it? Bug Fix ### TODO - [x] Fix test ### What is the Jira issue? [ZEPPELIN-1880](https://issues.apache.org/jira/browse/ZEPPELIN-1880) ### How should this be tested? ``` %sh date && sleep 3 && date ``` the each timestamp must be printed as streaming output ### Screenshots (if appropriate) - before  - after  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <[email protected]> Closes #1833 from AhyoungRyu/ZEPPELIN-1880 and squashes the following commits: 8fe33c4 [AhyoungRyu] Fix invalid test cases e2fd4bf [AhyoungRyu] Add test for shell inpt timeout property 34d3021 [AhyoungRyu] Fix shell intp streaming output result (cherry picked from commit 9b4a1bf) Signed-off-by: ahyoungryu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
After #611 merged, Zeppelin provides streaming output for spark and pyspark interpreter. For the further improvement, I changed a few code lines using
InterpreterContextso that sh interpreter can be available too.What type of PR is it?
Improvement
Todos
Is there a relevant Jira issue?
ZEPPELIN-646: Shell interpreter output streaming
ZEPPELIN-554: Streaming interpreter output to front-end
How should this be tested?
After applying this PR, run this below code with
shinterpreter in Zeppelin.Then you can see two timestamps which have 3 seconds gap.
Screenshots (if appropriate)
Questions: