fix + paragraph appearing in link #613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @MikeTYChen for really quick fix. Tested and Looks good to me. |
Contributor
|
Thank you for the quick fix !! 😀 |
Contributor
|
LGTM |
Member
|
Since 0.5.6 rc1 is in vote alreay, i'm merging it into master only. we can merge it into branch-0.5.6 anytime we want. |
Member
|
Looks great, thank you. It definitely belongs to 0.5.6, will merge there. |
asfgit
pushed a commit
that referenced
this pull request
Jan 11, 2016
### What is this PR for? Fix a bug where the + paragraph appears in link paragraph ### What type of PR is it? Bug Fix ### Todos ### Is there a relevant Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-591 ### How should this be tested? Click link paragraph in a paragraph and move mouse below paragraph. ### Screenshots (if appropriate) Before: <img width="1424" alt="before" src="https://cloud.githubusercontent.com/assets/6380209/12211555/8c4ea0ce-b627-11e5-83fb-4d9273542bc8.png"> After: <img width="1416" alt="after" src="https://cloud.githubusercontent.com/assets/6380209/12211560/96642fa2-b627-11e5-90d0-f2381f1b3c24.png"> ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Michael Chen <[email protected]> Closes #613 from MikeTYChen/ZEPPELIN-591 and squashes the following commits: 26dcea9 [Michael Chen] fix + paragraph appearing in link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix a bug where the + paragraph appears in link paragraph
What type of PR is it?
Bug Fix
Todos
Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-591
How should this be tested?
Click link paragraph in a paragraph and move mouse below paragraph.
Screenshots (if appropriate)
Before:
After:
Questions: