Skip to content

Conversation

@r-kamath
Copy link
Member

@r-kamath r-kamath commented Jan 7, 2016

What is this PR for?

Bug fix paragraph UI

What type of PR is it?

Bug Fix

Is there a relevant Jira issue?

ZEPPELIN-565 & ZEPPELIN-564

Screenshots (if appropriate)

Before
5
2 1


After
screen shot 2016-01-07 at 12 29 13 pm
screen shot 2016-01-07 at 12 29 33 pm

@corneadoug
Copy link
Contributor

I found one problem with this fix (or the new resize behavior).
Let's take a look at the notebook Zeppelin Tutorial. At first it is showing some graphs.
If we run a sql query (without the data), we will get an error which will burst out of the paragraph. (this PR fixes it).
If we then run the whole notebook, the query will run successfully and show a graph, however that graph height will be the one of the previous error.
screen shot 2016-01-08 at 9 41 18 am

Overall, the resizing aspect of the output is a bit tricky between content based height and manually set height.
TEXT type of output as well as HTML and ANGULAR are content based height.
Only TABLE type of output is responding to manually set height.

@bzz
Copy link
Member

bzz commented Jan 11, 2016

Guys, please let me know if this is ready to be merged - as we are about to restart the 0.5.6 release it can be a part of it, if ready.

@corneadoug
Copy link
Contributor

@bzz I'm gonna try to find a solution that solves all cases this afternoon based on that fix.
If I don't come up with something, let's merge this one

@corneadoug
Copy link
Contributor

I don't know how I got that case before, just tried again and got no problem.
LGTM

@prabhjyotsingh
Copy link
Contributor

Tested, LGTM.

@bzz
Copy link
Member

bzz commented Jan 11, 2016

Have updated fix-for version to 0.5.6 for both ZEPPELIN-564 and ZEPPELIN-565

Will merged to master and branch-0.5.6 if there is no more discussion.

@asfgit asfgit closed this in 3d4dc43 Jan 11, 2016
asfgit pushed a commit that referenced this pull request Jan 11, 2016
### What is this PR for?
Bug fix paragraph UI

### What type of PR is it?
Bug Fix

### Is there a relevant Jira issue?
ZEPPELIN-565 & ZEPPELIN-564

### Screenshots (if appropriate)
Before
![5](https://cloud.githubusercontent.com/assets/2031306/12164296/8cb54948-b53a-11e5-8f6c-792dfc83063d.PNG)
![2 1](https://cloud.githubusercontent.com/assets/2031306/12164297/8ec65bdc-b53a-11e5-9d5b-95c8585100b0.PNG)

<hr>
After
<img width="527" alt="screen shot 2016-01-07 at 12 29 13 pm" src="https://cloud.githubusercontent.com/assets/2031306/12164271/60a4068c-b53a-11e5-8909-f44c128d4916.png">
<img width="1671" alt="screen shot 2016-01-07 at 12 29 33 pm" src="https://cloud.githubusercontent.com/assets/2031306/12164277/695f542a-b53a-11e5-84eb-17a174c83733.png">

Author: Renjith Kamath <[email protected]>

Closes #606 from r-kamath/ZEPPELIN-560 and squashes the following commits:

aae30d2 [Renjith Kamath] ZEPPELIN-565 ZEPPELIN-564 Paragraph UI bugs

(cherry picked from commit 3d4dc43)
Signed-off-by: Alexander Bezzubov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants