Skip to content

Install guide modifications based on recent build attempts #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dcardon wants to merge 3 commits into from
Closed

Install guide modifications based on recent build attempts #543

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb0d6e5
Update README.md
dcardon Dec 16, 2015
2f05e0b
Update README.md
dcardon Dec 16, 2015
68fefd0
Removed unnecessary installs
dcardon Mar 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ sudo apt-get install git
sudo apt-get install openjdk-7-jdk
sudo apt-get install npm
sudo apt-get install libfontconfig
sudo npm -g install grunt-cli

@bzz bzz Dec 17, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, neither node, nor npm or
grunt-cli https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/package.json#L29
or bower https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/package.json#L10
are required to be installed manually on the environment, as they all are beeing taken care of by mvn package in zeppelin-web through the frontend-maven-pluging and there is a ./grunt wrapper for manual run too

@dcardon dcardon Dec 17, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this was not my experience. I followed these instructions on a fresh CentOS 7 install and the zeppelin-web module build failed without the npm install steps. Are you saying that it should work if you remove the sudo apt-get install npm step?

@bzz bzz Dec 17, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sharing the experience!

What I was trying to say is that mvn package was designed to build zeppelin on clean environment, including web application, without requirements to have node.js&npm pre-installed there.

If it does not work like that on some environments - it has to be a bug well worth firing a JIRA issue.
Having those things installed sounds like a reasonable workaround to me in such cases.

@dcardon dcardon Dec 17, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I totally agree it would be better to have these install automatically--I'll look and see if I can modify the pom.xml to get that working without the additional steps.

sudo npm -g install bower

# Optional: If you're limited to what ports you can access externally
# git config --global url."https://".insteadOf git://

# install maven
wget http://www.eu.apache.org/dist/maven/maven-3/3.3.3/binaries/apache-maven-3.3.3-bin.tar.gz
Expand Down