[ZEPPELIN-484] A small utility to help review the pullrequest.#513
[ZEPPELIN-484] A small utility to help review the pullrequest.#513Leemoonsoo wants to merge 4 commits into
Conversation
|
@Leemoonsoo I do |
|
@r-kamath solution looks simpler, both are hacky though 😃 |
|
I've tested. Looks good. It's enough to me to test pr. Thanks. |
|
Should we also include some: |
|
Looks great to me. Another way to do the same is a small It takes care of setting up a remote (so you can always pull from it later) and checking out a PR branch to your local repo. |
|
@Leemoonsoo If we want to go further with this tool, as we already have I feel that this, as well as a couple of lines of text comments in the header after the licence boilerplate, will give a better idea of it's purpose for people who will just notice it in the filesystem, what do you think? |
|
Thanks all the feedbacks and alternative solutions. I have changed script name from |
|
Looks great to me |
|
merging into master |
### What is this PR for? Zeppelin has already provided a useful utility for reviewing PR ( #513 ). So I added a **Testing a Pull Request** section to `CONTRIBUTING.md` for whom to review and test PR quickly. ### What type of PR is it? Documentation ### Todos * [x] - Add a **Testing a Pull Request** section to CONTRIBUTING.md ### Is there a relevant Jira issue? [ZEPPELIN-484](https://issues.apache.org/jira/browse/ZEPPELIN-484) and PR #513 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Ryu Ah young <fbdkdud93@hanmail.net> Closes #656 from AhyoungRyu/add_pr_review_information and squashes the following commits: 5f370d5 [Ryu Ah young] Fix some grammar errors 3781550 [Ryu Ah young] Delete 'like' 9ced186 [Ryu Ah young] Add some information about how we can review and test PR
This PR address https://issues.apache.org/jira/browse/ZEPPELIN-484.
We've got discussions recently about impasse of pullrequest and speeding up of accepting pullrequest.
This small utility can be used when reviewer want to test the pullrequest.
Usage is
for example
will create local branch
pr500and add remote repository of contribution, fetch and merge it for the test.This script will help reduce small bit of time of reviewing.