Skip to content

[ZEPPELIN-6307] Rename fieldname in NewNoteRequest class #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

[ZEPPELIN-6307] Rename fieldname in NewNoteRequest class #5055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ public Response createNote(String message) throws IOException {
defaultInterpreterGroup = zConf.getString(ZeppelinConfiguration.ConfVars.ZEPPELIN_INTERPRETER_GROUP_DEFAULT);
}
String noteId = notebookService.createNote(
request.getName(),
request.getNotePath(),
defaultInterpreterGroup,
request.getAddingEmptyParagraph(),
getServiceContext(),
Expand Down Expand Up @@ -571,7 +571,7 @@ public Response cloneNote(@PathParam("noteId") String noteId, String message)
String newNoteName = null;
String revisionId = null;
if (request != null) {
newNoteName = request.getName();
newNoteName = request.getNotePath();
revisionId = request.getRevisionId();
}
AuthenticationInfo subject = new AuthenticationInfo(authenticationService.getPrincipal());
Expand Down
11 changes: 5 additions & 6 deletions zeppelin-server/src/main/java/org/apache/zeppelin/rest/message/NewNoteRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,14 @@
*/
public class NewNoteRequest {

//TODO(zjffdu) rename it to be notePath instead of name
private final String name;
private final String notePath;
private final String defaultInterpreterGroup;
private final Boolean addingEmptyParagraph;
private final List<NewParagraphRequest> paragraphs;
private final String revisionId;

public NewNoteRequest(String name, String defaultInterpreterGroup, Boolean addingEmptyParagraph, List<NewParagraphRequest> paragraphs, String revisionId) {
this.name = name;
public NewNoteRequest(String notePath, String defaultInterpreterGroup, Boolean addingEmptyParagraph, List<NewParagraphRequest> paragraphs, String revisionId) {
this.notePath = notePath;
this.defaultInterpreterGroup = defaultInterpreterGroup;
this.addingEmptyParagraph = addingEmptyParagraph;
this.paragraphs = paragraphs;
Expand All @@ -49,8 +48,8 @@ public boolean getAddingEmptyParagraph() {
return addingEmptyParagraph.booleanValue();
}

public String getName() {
return name;
public String getNotePath() {
return notePath;
}

public String getDefaultInterpreterGroup() {
Expand Down
Loading