-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class #5029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+79
−0
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9d366a2
[ZEPPELIN-6281] Add Unit Tests for LivyVersion Class
celinayk 017ad90
[ZEPPELIN-6281] Add Apache license header and replace wildcard import…
celinayk 8349072
[ZEPPELIN-6281] Add newline at end of LivyVersionTest.java
celinayk ed8791d
[ZEPPELIN-6281] Add 1 newline at end of LivyVersionTest.java
celinayk 301ef61
[ZEPPELIN-6281] Add only 1 newline at end of LivyVersionTest.java
celinayk 0d8d997
[ZEPPELIN-6281] checkstyle edit of LivyVersionTest.java
celinayk 792ea8b
[ZEPPELIN-6281] separate the license header of LivyVersionTest.java
celinayk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
77 changes: 77 additions & 0 deletions
77
livy/src/test/java/org/apache/zeppelin/livy/LivyVersionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.zeppelin.livy; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
|
|
||
| class LivyVersionTest { | ||
|
|
||
| @Test | ||
| void testVersionParsing() { | ||
| LivyVersion v = new LivyVersion("1.6.2"); | ||
| assertEquals(10602, v.toNumber()); | ||
| assertEquals("1.6.2", v.toString()); | ||
| } | ||
|
|
||
| @Test | ||
| void testPreReleaseVersionParsing() { | ||
| LivyVersion v = new LivyVersion("0.6.0-SNAPSHOT"); | ||
| assertEquals(600, v.toNumber()); | ||
| assertEquals("0.6.0-SNAPSHOT", v.toString()); | ||
| } | ||
|
|
||
| @Test | ||
| void testComparisonLogic() { | ||
| LivyVersion v1 = new LivyVersion("0.5.0"); | ||
| LivyVersion v2 = new LivyVersion("0.4.0"); | ||
| assertTrue(v1.newerThan(v2)); | ||
| assertTrue(v2.olderThan(v1)); | ||
| assertFalse(v2.newerThan(v1)); | ||
| assertFalse(v1.olderThan(v2)); | ||
| } | ||
|
|
||
| @Test | ||
| void testInvalidVersionString() { | ||
| LivyVersion v1 = new LivyVersion("invalid"); | ||
| assertEquals(99999, v1.toNumber()); | ||
|
|
||
| LivyVersion v2 = new LivyVersion(null); | ||
| assertEquals(99999, v2.toNumber()); | ||
| } | ||
|
|
||
| @Test | ||
| void isCancelSupported() { | ||
| assertTrue(new LivyVersion("0.3.0").isCancelSupported()); | ||
| assertFalse(new LivyVersion("0.2.0").isCancelSupported()); | ||
| } | ||
|
|
||
| @Test | ||
| void isSharedSupported() { | ||
| assertTrue(new LivyVersion("0.5.0").isSharedSupported()); | ||
| assertFalse(new LivyVersion("0.4.0").isSharedSupported()); | ||
| } | ||
|
|
||
| @Test | ||
| void isGetProgressSupported() { | ||
| assertTrue(new LivyVersion("0.4.0").isGetProgressSupported()); | ||
| assertFalse((new LivyVersion("0.3.0")).isGetProgressSupported()); | ||
| } | ||
| } | ||
Reamer marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.