[ZEPPELIN-6203] Connect shortcut modal for info button #4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dididy Can we add some tests for it? |
Are you referring to E2E test? |
|
Yes, it would be great if we have. |
dididy
changed the title
Because in the current Monaco editor, autocomplete works by default without requiring a shortcut.
dididy
force-pushed
the
fix/ZEPPELIN-6203
branch
from
6d5c655 to
6e75ed6
Compare
|
87c4d19 6e75ed6 https://issues.apache.org/jira/browse/ZEPPELIN-6314 I’m currently looking into the E2E environment setup, and the Jira ticket is as above. It will likely use Playwright. #5044 / #5064 |
tbonelee
reviewed
Sep 6, 2025
tbonelee
pushed a commit
that referenced
this pull request
Sep 7, 2025
### What is this PR for? <img width="417" height="103" alt="image" src="https://github.com/user-attachments/assets/d4fca2f3-0dca-43ae-b159-ca881bd1766d" /> Nothing happened when I click above info button inside of Zeppelin Notebook. So I connect this function work properly. This button related in [here](https://github.com/apache/zeppelin/blob/526eb15b8732909ab994adba76e0c3e33bfa001c/zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.ts#L239) so I made shared shortcut component and connect it. Now it works well. <img width="1624" height="1056" alt="스크린샷 2025-07-12 오후 6 10 05" src="https://github.com/user-attachments/assets/d71e7264-eefb-4e80-bf4d-cf4467627d5e" /> I refer to [zeppelin-web's shortcut file](https://github.com/apache/zeppelin/blob/526eb15b8732909ab994adba76e0c3e33bfa001c/zeppelin-web/src/app/notebook/shortcut.html) ### What type of PR is it? Bug Fix Feature Refactoring ### Todos * [x] makes html file's isMac working well * [ ] Adjust shortcut for zeppelin-web to zeppelin-web-angular / check this file for preventing weird working when user try to use shortcut // [here](https://github.com/apache/zeppelin/blob/526eb15b8732909ab994adba76e0c3e33bfa001c/zeppelin-web-angular/src/app/services/shortcut.service.ts) [ZEPPELIN-6229](https://issues.apache.org/jira/browse/ZEPPELIN-6229) [ZEPPELIN-6197](https://issues.apache.org/jira/browse/ZEPPELIN-6197) * [ ] Made "Clone paragraph" button work properly in New UI // [ZEPPELIN-6294](https://issues.apache.org/jira/browse/ZEPPELIN-6294) ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6203 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #4963 from dididy/fix/ZEPPELIN-6203. Signed-off-by: ChanHo Lee <[email protected]> (cherry picked from commit 0f20ffc) Signed-off-by: ChanHo Lee <[email protected]>
|
Merged into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Nothing happened when I click above info button inside of Zeppelin Notebook. So I connect this function work properly.
This button related in here so I made shared shortcut component and connect it. Now it works well.
I refer to zeppelin-web's shortcut file
What type of PR is it?
Bug Fix
Feature
Refactoring
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6203
How should this be tested?
Screenshots (if appropriate)
Questions: