-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-6143] Add Interpreter Event Server Port configuration option #4893
[ZEPPELIN-6143] Add Interpreter Event Server Port configuration option #4893
Conversation
I understand your approach. Currently I use the |
@Reamer However, aligning with previous variable names might improve predictability as well, which is why I didn't have a strong preference for the former option from the beginning. What do you think? |
I favor |
@Reamer Thanks for the feedback. I've added some commits based on your suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
### What is this PR for? This PR introduces the `ZEPPELIN_EVENT_SERVER_PORT` configuration option. When this option is set, the Event server that communicates with interpreters will listen on the specified port. The `ZEPPELIN_EVENT_SERVER_PORT` option takes precedence over `ZEPPELIN_SERVER_RPC_PORTRANGE` option. If `ZEPPELIN_EVENT_SERVER_PORT` is set, the `ZEPPELIN_SERVER_RPC_PORTRANGE` range will be ignored. This option is particularly useful when running individual Zeppelin components in container orchestration environments like Kubernetes. By explicitly specifying the port, it allows for a more declarative and clearer configuration of service resources compared to `ZEPPELIN_SERVER_RPC_PORTRANGE`. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-6143 ### How should this be tested? * Run Zeppelin with and without this configuration and check zeppelin-server logs for the message `"InterpreterEventServer is starting at "`. Verify that the specified port is used as intended(If the option is set). ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes Closes #4893 from tbonelee/add-fixed-interpreter-event-server-port-option. Signed-off-by: Philipp Dallig <[email protected]> (cherry picked from commit f3551eb) Signed-off-by: Philipp Dallig <[email protected]>
What is this PR for?
This PR introduces the
ZEPPELIN_EVENT_SERVER_PORT
configuration option.When this option is set, the Event server that communicates with interpreters will listen on the specified port.
The
ZEPPELIN_EVENT_SERVER_PORT
option takes precedence overZEPPELIN_SERVER_RPC_PORTRANGE
option.If
ZEPPELIN_EVENT_SERVER_PORT
is set, theZEPPELIN_SERVER_RPC_PORTRANGE
range will be ignored.This option is particularly useful when running individual Zeppelin components in container orchestration environments like Kubernetes.
By explicitly specifying the port, it allows for a more declarative and clearer configuration of service resources compared to
ZEPPELIN_SERVER_RPC_PORTRANGE
.What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
"InterpreterEventServer is starting at "
. Verify that the specified port is used as intended(If the option is set).Questions: