-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[DRAFT] [ZEPPELIN-5722] Improve PluginManager #4355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I like this kind of improvement :-) BTW, did you have any experience with PF4J before? I heard it for the first time so I just wonder if you are already familiar with it or not. |
Not at all, I came across the project with with a quick Google query "Java Plugin Framework". |
|
Thank you for the reply. I feel like it's fairly enough. |
|
@zjffdu For a first feedback I would be very grateful. |
...docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java
Outdated
Show resolved
Hide resolved
...docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterLauncher.java
Outdated
Show resolved
Hide resolved
...-plugins/notebookrepo/mongo/src/main/java/org/apache/zeppelin/notebook/repo/MongoPlugin.java
Outdated
Show resolved
Hide resolved
|
@jongyoul |
I, totally, agree with you. It would be better to adopt it but to do it, we might need effort to do it. Do you have any idea to do it? Otherwise, we could add some code to ZeppelinServer to enable them. |
|
This pull request has been inactive for over a year. If no further activity occurs within the next 30 days, it will be automatically closed. If you believe this PR is still relevant, please feel free to leave a comment or make an update. Thank you! |
|
The implementation still needs to be thought through. |
What is this PR for?
This pull request extends the existing PluginManager. The Java Plugin Framework PF4J is used for this purpose. My goal of this change is a better separation of Java libraries to avoid overlapping dependencies.
The following change after this PullRequest makes sense to me:
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: