ZEPPELIN-383 Override classpath with ZEPPELIN_CLASSPATH_OVERRIDES #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Member
|
merge if there're no more discussions |
Member
|
looks good |
| @@ -121,9 +121,9 @@ fi | |||
| CLASSPATH+=":${ZEPPELIN_CLASSPATH}" | |||
|
|
|||
| if [[ -n "${SPARK_SUBMIT}" ]]; then | |||
| ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path "${CLASSPATH}" --driver-java-options "${JAVA_INTP_OPTS}" ${SPARK_SUBMIT_OPTIONS} ${SPARK_APP_JAR} ${PORT} & | |||
| ${SPARK_SUBMIT} --class ${ZEPPELIN_SERVER} --driver-class-path "${ZEPPELIN_CLASSPATH_OVERRIDESS}:${CLASSPATH}" --driver-java-options "${JAVA_INTP_OPTS}" ${SPARK_SUBMIT_OPTIONS} ${SPARK_APP_JAR} ${PORT} & | |||
Member
There was a problem hiding this comment.
@echarles Variable name ends with double S. Maybe its typo?
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2015
#412 fix :: bin/interpreter.sh ZEPPELIN_CLASSPATH_OVERRIDE**SS** -> ZEPPELIN_CLASSPATH_OVERRIDE**S** Author: Chae-Sung Lim <estail7s@gmail.com> Closes #422 from cloverhearts/ZEPPELIN-383-Additional_modifications and squashes the following commits: 90a267e [Chae-Sung Lim] ZEPPELIN-383-Additional_modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepend ZEPPELIN_CLASSPATH_OVERRIDES environment variable when building CLASSPATH in the shell scripts.
This PR replaces the closed #398 and #386 - Sorry for the mess...