Skip to content

Conversation

@blrunner
Copy link
Contributor

I succeed to test on local tajo cluster and distributed tajo cluster and I borrowed some classes from apache commons dbcp2 for unit test implementation.

Please see following site.
https://issues.apache.org/jira/browse/ZEPPELIN-45

@Leemoonsoo
Copy link
Member

Thanks for the contribution!
Let me test this.

@Leemoonsoo
Copy link
Member

Tested and works well.
One more thing is, could you add TajoInterpreter class to the default configuration in ZeppelinConfiguration? line 383, ZEPPELIN_INTERPRETERS property.
This values are used when zeppelin-site.xml is not exists.

@blrunner
Copy link
Contributor Author

Hi @Leemoonsoo

Thanks for your review. I've updated this as follows.

  • Added this to ZeppelinConfiguration for default configuration.
  • Updated Tajo builder order because it had caused a problem to ProtocolBuffer dependency.
  • Updated ZeppelinRestApiTest::getAvailableInterpreters

And if you authorize me to assign JIRA issue, it would be better for me to contribute Zeppelin continuously.

Cheers
Jaehwa

@blrunner
Copy link
Contributor Author

I found that ProtocolBuffer wrong version had been downloaded occasionally. I'm digging this.

@blrunner
Copy link
Contributor Author

I fixed a bug about protobuf version.

@Leemoonsoo
Copy link
Member

Looks good to me!

@asfgit asfgit closed this in 3a4ab1a Apr 24, 2015
@bzz bzz mentioned this pull request Sep 25, 2015
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants