[ZEPPELIN-4941]. added support for personalized configuration of JDBCInterpreter database connection pool #3844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interpreter may not be restarted when the interpreter process exits unexpectedly
Branch 0.9
…d to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete.
Branch 0.9
Branch 0.9 update
…ration to cope with scenarios such as HiveSession timeout
Contributor
|
Thanks for the contribution @xiejiajun Could you update |
Contributor
Author
@zjffdu Ok, I have updated the jdbc.md document for this feature. |
zjffdu
reviewed
Jul 8, 2020
| | maxTotal | -1 | The maximum number of active connections that can be allocated from this pool at the same time, or negative for no limit. | | ||
| | validationQuery | show database | The SQL query that will be used to validate connections from this pool before returning them to the caller. If specified, this query MUST be an SQL SELECT statement that returns at least one row. If not specified, connections will be validation by calling the isValid() method. | | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
You can use html table to render this. Here's one example of spark interpreter.
https://github.com/apache/zeppelin/blob/master/docs/interpreter/spark.md
Contributor
Author
There was a problem hiding this comment.
You can use html table to render this. Here's one example of spark interpreter.
https://github.com/apache/zeppelin/blob/master/docs/interpreter/spark.md
@zjffdu OK, I have updated the datasource pool docs in the jdbc.md with the html table syntax.
asfgit
pushed a commit
that referenced
this pull request
Jul 12, 2020
…Interpreter database connection pool ### What is this PR for? - Added support for personalized configuration of the JDBCInterpreter database connection pool. - This feature can be used to solve the runtime error caused by HiveServer2 Session timeout. - This connection pool configuration Compatible with [the official configuration of dbcp2 ](http://commons.apache.org/proper/commons-dbcp/configuration.html) ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4941 ### How should this be tested? * manually tested * Supported configuration items - validationQuery - testOnBorrow - testOnCreate - testOnReturn - testWhileIdle - timeBetweenEvictionRunsMillis - maxWaitMillis - maxIdle - minIdle - maxTotal ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: xiejiajun <[email protected]> Author: JakeXie <[email protected]> Author: xie-jia-jun <[email protected]> Closes #3844 from xiejiajun/jdbc-pool-config and squashes the following commits: 3bb622b [xiejiajun] use html table display datasource pool configuration in the jdbc.md document 88b1ce0 [xiejiajun] jdbc interpreter datasource connection pool document 1f2eb55 [xiejiajun] Compatible with the official configuration of dbcp2 connection pool 5c7f666 [xiejiajun] JDBCInterprete supports personalized database connection pool configuration to cope with scenarios such as HiveSession timeout 3d57719 [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into apache-0.9 0e5f65a [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into apache-0.9 076668a [JakeXie] Merge pull request #7 from apache/branch-0.9 00e14dd [JakeXie] Merge pull request #5 from apache/branch-0.9 9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9 9bc5605 [xiejiajun] bug fix: when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete. 97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9 9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Aug 14, 2020
…Interpreter database connection pool ### What is this PR for? - Added support for personalized configuration of the JDBCInterpreter database connection pool. - This feature can be used to solve the runtime error caused by HiveServer2 Session timeout. - This connection pool configuration Compatible with [the official configuration of dbcp2 ](http://commons.apache.org/proper/commons-dbcp/configuration.html) ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4941 ### How should this be tested? * manually tested * Supported configuration items - validationQuery - testOnBorrow - testOnCreate - testOnReturn - testWhileIdle - timeBetweenEvictionRunsMillis - maxWaitMillis - maxIdle - minIdle - maxTotal ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO Author: xiejiajun <[email protected]> Author: JakeXie <[email protected]> Author: xie-jia-jun <[email protected]> Closes apache#3844 from xiejiajun/jdbc-pool-config and squashes the following commits: 3bb622b [xiejiajun] use html table display datasource pool configuration in the jdbc.md document 88b1ce0 [xiejiajun] jdbc interpreter datasource connection pool document 1f2eb55 [xiejiajun] Compatible with the official configuration of dbcp2 connection pool 5c7f666 [xiejiajun] JDBCInterprete supports personalized database connection pool configuration to cope with scenarios such as HiveSession timeout 3d57719 [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into apache-0.9 0e5f65a [xiejiajun] Merge branch 'branch-0.9' of https://github.com/apache/zeppelin into apache-0.9 076668a [JakeXie] Merge pull request apache#7 from apache/branch-0.9 00e14dd [JakeXie] Merge pull request apache#5 from apache/branch-0.9 9bb7341 [xiejiajun] Merge remote-tracking branch 'origin/branch-0.9' into branch-0.9 9bc5605 [xiejiajun] bug fix: when we removing a paragraph , an interpreter process refused to connect due to it abnormal stop , which eventually caused the remove paragraph operation to fail to complete. 97d2714 [xie-jia-jun] Merge pull request #2 from apache/branch-0.9 9b3c744 [xiejiajun] added timeout for getting Thrift client to avoid situations where the interpreter may not be restarted when the interpreter process exits unexpectedly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: