Skip to content

[ZEPPELIN-4756] Cassandra: Show "No Results" message folded#3801

Closed
alexott wants to merge 1 commit intoapache:masterfrom
alexott:ZEPPELIN-4756
Closed

[ZEPPELIN-4756] Cassandra: Show "No Results" message folded#3801
alexott wants to merge 1 commit intoapache:masterfrom
alexott:ZEPPELIN-4756

Conversation

@alexott
Copy link
Contributor

@alexott alexott commented Jun 14, 2020

What is this PR for?

Right now, when operation returns no results, for example, when executing most operations other than SELECT (DDL/INSERT/UPDATE/DELETE/...), interpreter shows the extended information - what hosts were used to execute command, etc. This information occupies a significant amount of the screen space and isn't critical for execution.

Given PR provides the same information but folds it by default, saving the screen space.

What type of PR is it?

Improvement

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Old view:

Screen Shot 2020-04-15 at 08 47 20

New view:

Screenshot from 2020-06-14 11-33-14

Screenshot from 2020-06-14 11-33-38

@zjffdu
Copy link
Contributor

zjffdu commented Jun 16, 2020

@alexott PR description needs to be updated

@alexott
Copy link
Contributor Author

alexott commented Jun 17, 2020

@zjffdu sorry, forgot - fixed now

@zjffdu
Copy link
Contributor

zjffdu commented Jun 17, 2020

LGTM

@asfgit asfgit closed this in 84b6a1b Jun 17, 2020
asfgit pushed a commit that referenced this pull request Jun 17, 2020
### What is this PR for?

Right now, when operation returns no results, for example, when executing most operations other than `SELECT` (DDL/INSERT/UPDATE/DELETE/...), interpreter shows the extended information - what hosts were used to execute command, etc. This information occupies a significant amount of the screen space and isn't critical for execution.

Given PR provides the same information but folds it by default, saving the screen space.

### What type of PR is it?
Improvement

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4756

### How should this be tested?
* https://travis-ci.org/github/alexott/zeppelin/builds/698161348

### Screenshots (if appropriate)

Old view:

![Screen Shot 2020-04-15 at 08 47 20](https://user-images.githubusercontent.com/30342/84589948-aea70280-ae32-11ea-8839-d5585de2c47c.png)

New view:

![Screenshot from 2020-06-14 11-33-14](https://user-images.githubusercontent.com/30342/84589981-eb72f980-ae32-11ea-99e8-c6bb7ec54843.png)

![Screenshot from 2020-06-14 11-33-38](https://user-images.githubusercontent.com/30342/84589983-ee6dea00-ae32-11ea-8112-c3694e51a425.png)

Author: Alex Ott <alexott@gmail.com>

Closes #3801 from alexott/ZEPPELIN-4756 and squashes the following commits:

3b0618c [Alex Ott] [ZEPPELIN-4756] Cassandra: Show "No Results" message folded

(cherry picked from commit 84b6a1b)
Signed-off-by: Alex Ott <alexott@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants