[ZEPPELIN-4870][hotfix] fix edge case, and remove duplicate parser#3800
Closed
alexott wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4870][hotfix] fix edge case, and remove duplicate parser#3800alexott wants to merge 1 commit intoapache:masterfrom
alexott wants to merge 1 commit intoapache:masterfrom
Conversation
alexott
force-pushed
the
ZEPPELIN-4870-hotfix
branch
from
d49e765 to
d4b2e03
Compare
alexott
changed the title
Tests didn't cover all of the edge cases, that lead to error when parsing specific message. Also, was found that parsing is also duplicated in the `Paragraph` class - it was replaced with call to `ParagraphTextParser`
alexott
force-pushed
the
ZEPPELIN-4870-hotfix
branch
from
d4b2e03 to
5942c5d
Compare
alexott
changed the title
Contributor
Author
|
@zjffdu can you look when you have a time... |
Contributor
|
LGTM |
asfgit
pushed a commit
that referenced
this pull request
Jun 14, 2020
### What is this PR for? Tests didn't cover all of the edge cases, that lead to error when parsing specific message. Also, was found that parsing is also duplicated in the `Paragraph` class - it was replaced with call to `ParagraphTextParser`. The most visible change is that `%interpreter(some text` will know fail as there is no matching `)` character. But it's works the same if we change it to `%interpreter (some text`... ### What type of PR is it? Hot Fix ### What is the Jira issue? * ZEPPELIN-4870 ### How should this be tested? * Added one more test * https://travis-ci.org/github/alexott/zeppelin/builds/697944179 Author: Alex Ott <alexott@gmail.com> Closes #3800 from alexott/ZEPPELIN-4870-hotfix and squashes the following commits: 5942c5d [Alex Ott] [ZEPPELIN-4870][hotfix] fix edge case, and remove duplicate parser (cherry picked from commit d679bb1) Signed-off-by: Alex Ott <alexott@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Tests didn't cover all of the edge cases, that lead to error when parsing specific message.
Also, was found that parsing is also duplicated in the
Paragraphclass - it was replaced with call toParagraphTextParser.The most visible change is that
%interpreter(some textwill know fail as there is no matching)character. But it's works the same if we change it to%interpreter (some text...What type of PR is it?
Hot Fix
What is the Jira issue?
How should this be tested?