[ZEPPELIN-4851]. Add property to flink interpreter to allow replace the yarn address#3797
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4851]. Add property to flink interpreter to allow replace the yarn address#3797zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
alexott
reviewed
Jun 11, 2020
| } | ||
|
|
||
| private def replaceYarnAddress(webURL: String, yarnAddress: String): String = { | ||
| val pattern = "(http://.*:\\d+)(/.*)".r |
Contributor
There was a problem hiding this comment.
I maybe would change it to the to parsing of webURL into URL or URI, and construction of the new object, but with changed components.
Also it won't handle https schema, etc.
Contributor
Author
There was a problem hiding this comment.
@alexott URL doesn't expose set method. So it is not easy to construct URL with components, however I fixed the https issue and also add unit tests
asfgit
pushed a commit
that referenced
this pull request
Jun 17, 2020
…he yarn address ### What is this PR for? Trivial PR which add property `flink.webui.yarn.yarnAddress` that allow user to replace the yarn address. This is for some cases that cloud vender would map the internal resource manager address to other url. e.g. some cloud vender will map `http://resource-manager:8088` to `https://xxx-yarn.yy.cn/gateway/kkk/yarn` ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4851 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jeff Zhang <zjffdu@apache.org> Closes #3797 from zjffdu/ZEPPELIN-4851 and squashes the following commits: c1be762 [Jeff Zhang] [ZEPPELIN-4851]. Add property to flink interpreter to allow replace the yarn address (cherry picked from commit 2b505dc) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Trivial PR which add property
flink.webui.yarn.yarnAddressthat allow user to replace the yarn address. This is for some cases that cloud vender would map the internal resource manager address to other url. e.g. some cloud vender will maphttp://resource-manager:8088tohttps://xxx-yarn.yy.cn/gateway/kkk/yarnWhat type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: