[ZEPPELIN-4878]. Unable to run flink 1.10.1 in yarn mode due to FLINK-17788#3795
[ZEPPELIN-4878]. Unable to run flink 1.10.1 in yarn mode due to FLINK-17788#3795zjffdu wants to merge 2 commits intoapache:masterfrom
Conversation
| <name>Zeppelin: Flink1.10 Shims</name> | ||
|
|
||
| <properties> | ||
| <flink.version>1.10.0</flink.version> |
There was a problem hiding this comment.
does it make sense to define a constant in the flink-parent so it will be shared?
There was a problem hiding this comment.
I am afraid not. I plan to add profile flink-1.10 and flink-1.11 for flink interpreter after flink 1.11 is released. But flink.version in flink1.10-shims will not be affected by profile, it should always be flink 1.10, flink.version in flink/interpreter module will be affected by this profile, and will run test under flink/interpreter for different flink version.
There was a problem hiding this comment.
I meant, that we can define property, like, <flink.1.10.version> and refer to it... I did this for Hadoop:
<hadoop2.7.version>2.7.7</hadoop2.7.version>
<hadoop2.6.version>2.6.5</hadoop2.6.version>
<hadoop3.0.version>3.0.3</hadoop3.0.version>
<hadoop3.1.version>3.1.3</hadoop3.1.version>
and then use it as ${hadoop3.1.version}, etc.
There was a problem hiding this comment.
Good idea, I have fixed it
…-17788 ### What is this PR for? Flink interpreter doesn't work with flink 1.10.1 in yarn mode due to FLINK-17788, this PR fix it in zeppelin side. Because in scala shell, flink only support yarn session mode, so when it is yarn mode, we can set deployment target to be yarn-session directly. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4878 ### How should this be tested? * CI pass and manually tested ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3795 from zjffdu/ZEPPELIN-4878 and squashes the following commits: 498325c [Jeff Zhang] use flink1.10.version & flink1.11.version fb1a761 [Jeff Zhang] [ZEPPELIN-4878]. Unable to run flink 1.10.1 in yarn mode due to FLINK-17788 (cherry picked from commit 951da42) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
2 participants
What is this PR for?
Flink interpreter doesn't work with flink 1.10.1 in yarn mode due to FLINK-17788, this PR fix it in zeppelin side. Because in scala shell, flink only support yarn session mode, so when it is yarn mode, we can set deployment target to be yarn-session directly.
What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: