[ZEPPELIN-4852]. Add name to RemoteInterpreterProcess#3785
Closed
zjffdu wants to merge 3 commits intoapache:masterfrom
Closed
[ZEPPELIN-4852]. Add name to RemoteInterpreterProcess#3785zjffdu wants to merge 3 commits intoapache:masterfrom
zjffdu wants to merge 3 commits intoapache:masterfrom
Conversation
Reamer
reviewed
Jun 4, 2020
|
|
||
| // Shutdown connection | ||
| shutdown(); | ||
| logger.info("Remote process of interpreter group: " + getInterpreterGroupId() + " is terminated"); |
Contributor
There was a problem hiding this comment.
Could you please make the logger 'public static final' and avoid the creation of objects if the logger is disabled for the INFO level ( LOGGER.info(String format, Object... arguments);).
Reamer
reviewed
Jun 4, 2020
| public void stop() { | ||
| if (isRunning()) { | ||
| LOGGER.info("Kill interpreter process"); | ||
| LOGGER.info("Kill interpreter process for interpreter group: " + getInterpreterGroupId()); |
Contributor
There was a problem hiding this comment.
We should avoid the creation of objects if a logging level is disabled. String concatenation creates a new String object.
This particular line should change to
LOGGER.info("Kill interpreter process for interpreter group: {}", getInterpreterGroupId());
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2020
### What is this PR for? This is a trivial PR which add `getInterpreterGroupId` to `InterpreterClient`, and use `interpreterGroupId` as the identifier of RemoteInterpreterProcess because `interpreterGroupId` is also unique identifier of InterpreterGroup ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4852 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3785 from zjffdu/ZEPPELIN-4852 and squashes the following commits: 01ec893 [Jeff Zhang] address comment 4fc92cc [Jeff Zhang] address comment a482faa [Jeff Zhang] [ZEPPELIN-4852]. Add name to RemoteInterpreterProcess (cherry picked from commit 2ab8f9e) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a trivial PR which add
getInterpreterGroupIdtoInterpreterClient, and useinterpreterGroupIdas the identifier of RemoteInterpreterProcess becauseinterpreterGroupIdis also unique identifier of InterpreterGroupWhat type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: