[ZEPPELIN-4833] misleading logging when fail to load plugin from classpath directly#3784
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4833] misleading logging when fail to load plugin from classpath directly#3784zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
zjffdu
changed the title
zjffdu
force-pushed
the
ZEPPELIN-4833
branch
2 times, most recently
from
f5aa380 to
a757c87
Compare
asfgit
pushed a commit
that referenced
this pull request
Jun 8, 2020
…spath directly ### What is this PR for? Previous plugin loading strategy is to load them from system classloader first, if fails, then fallback to plugin folder classloader. This would produce misleading logging which make user think that the plugin is failed to load. This PR would load plugin from system classloader only when they are builtin plugins. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4833 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3784 from zjffdu/ZEPPELIN-4833 and squashes the following commits: 62cd4db [Jeff Zhang] [ZEPPELIN-4833] misleading logging when fail to load plugin from classpath directly (cherry picked from commit 11780d3) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Previous plugin loading strategy is to load them from system classloader first, if fails, then fallback to plugin folder classloader. This would produce misleading logging which make user think that the plugin is failed to load. This PR would load plugin from system classloader only when they are builtin plugins.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: