Skip to content

[ZEPPELIN-4845]. Recover running paragraph when recovery is enabled#3781

Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4845
Closed

[ZEPPELIN-4845]. Recover running paragraph when recovery is enabled#3781
zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu:ZEPPELIN-4845

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jun 1, 2020

What is this PR for?

This PR is to recover the running paragraph when recovery is enabled.

  1. Get all the running Interpreter processes from RecoveryStorage.
  2. Reconnect to the running interpreter process.
  3. Resubmit the paragraph to interpreter process.

What type of PR is it?

[ Feature]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass and manully tested the recovery scenairo.

Screenshots (if appropriate)

ezgif com-video-to-gif (1)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu zjffdu force-pushed the ZEPPELIN-4845 branch 2 times, most recently from 8df38a0 to 261eb39 Compare June 1, 2020 08:04
buildEnvFromProperties(context),
getZeppelinService(),
getZeppelinServiceRpcPort(),
Integer.parseInt(getZeppelinServiceRpcPort()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change the return value of getZeppelinServiceRpcPort() to int.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, let me update it.

@zjffdu zjffdu force-pushed the ZEPPELIN-4845 branch 11 times, most recently from 0ecb0a7 to 5c9eb7c Compare June 8, 2020 02:47
@zjffdu zjffdu force-pushed the ZEPPELIN-4845 branch 6 times, most recently from 3252f27 to 12c35e2 Compare June 9, 2020 14:16
@asfgit asfgit closed this in 446608f Jun 10, 2020
asfgit pushed a commit that referenced this pull request Jun 10, 2020
### What is this PR for?

This PR is to recover the running paragraph when recovery is enabled.
1. Get all the running Interpreter processes from RecoveryStorage.
2. Reconnect to the running interpreter process.
3. Resubmit the paragraph to interpreter process.

### What type of PR is it?
[ Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4845

### How should this be tested?
* CI pass and manully tested the recovery scenairo.

### Screenshots (if appropriate)

![ezgif com-video-to-gif (1)](https://user-images.githubusercontent.com/164491/83387264-013df300-a41f-11ea-9170-091af76037e0.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #3781 from zjffdu/ZEPPELIN-4845 and squashes the following commits:

2302471 [Jeff Zhang] [ZEPPELIN-4845]. Recover running paragraph when recovery is enabled

(cherry picked from commit 446608f)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants