[ZEPPELIN-4802]. pyspark warnings with spark-3.0.0-preview - Sync of properties between JVM and PVM#3778
Closed
zjffdu wants to merge 1 commit intoapache:masterfrom
Closed
[ZEPPELIN-4802]. pyspark warnings with spark-3.0.0-preview - Sync of properties between JVM and PVM#3778zjffdu wants to merge 1 commit intoapache:masterfrom
zjffdu wants to merge 1 commit intoapache:masterfrom
Conversation
…properties between JVM and PVM
Contributor
Author
|
@Reamer Could you help review it ? |
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2020
…properties between JVM and PVM ### What is this PR for? This PR will first set env `PYSPARK_PIN_THREAD` to be `true` and then suppress the warning message in `pyspark.util`. ### What type of PR is it? [Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4802 ### How should this be tested? * CI pass * Manually tested ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? No * Does this needs documentation? Author: Jeff Zhang <zjffdu@apache.org> Closes #3778 from zjffdu/ZEPPELIN-4802 and squashes the following commits: d6a65cb [Jeff Zhang] [ZEPPELIN-4802]. pyspark warnings with spark-3.0.0-preview - Sync of properties between JVM and PVM (cherry picked from commit df86e50) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Contributor
I can confirm that the warnings are gone, but it is a good code style to ignore all warnings from `pyspark.util'. |
Contributor
Author
|
@Reamer I looked at the source code of spark, no matter what user do, it would always print warning message, so I think suppressing the warning is the only way to do that. https://github.com/apache/spark/blob/master/python/pyspark/util.py#L117 |
Contributor
|
Thank you very much for your explanation. Always printing out a warning message is not a good solution. Therefore I also think that suppressing the warning is a good way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR will first set env
PYSPARK_PIN_THREADto betrueand then suppress the warning message inpyspark.util.What type of PR is it?
[Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: