[ZEPPELIN-4805]. Error Stack Trace not received on rest API #3772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
approved these changes
May 15, 2020
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
LGTM, only small comment on Javadoc
| * @param blocking | ||
| * @param context | ||
| * @param callback | ||
| * @return |
Contributor
There was a problem hiding this comment.
should we move "return true only when ..." here and at beginning something like "executes given paragraph"...?
asfgit
pushed a commit
that referenced
this pull request
May 19, 2020
### What is this PR for? This PR is to fix the issue that no error message returned of running paragraph. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4805 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Jeff Zhang <[email protected]> Closes #3772 from zjffdu/ZEPPELIN-4805 and squashes the following commits: e8ed2f0 [Jeff Zhang] [ZEPPELIN-4805]. Error Stack Trace not received on rest API (cherry picked from commit 69722ff) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is to fix the issue that no error message returned of running paragraph.
What type of PR is it?
[Bug Fix ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: