[ZEPPELIN-4726] Use entry.user & entry.password instead of user.entry and password.entry for credential injection #3771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
approved these changes
May 15, 2020
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
LGTM.
I'm only thinking - should we have to document somewhere such "breaking" changes that will require migration of the existing notebooks that will stop work
Contributor
Author
|
Document is updated |
… and password.entry for credential injection
asfgit
pushed a commit
that referenced
this pull request
May 19, 2020
… and password.entry for credential injection ### What is this PR for? This is a refactoring PR which just use entry.user & entry.password instead of user.entry and password.entry for credential injection . ### What type of PR is it? [Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4726 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3771 from zjffdu/ZEPPELIN-4726 and squashes the following commits: fb3a8cb [Jeff Zhang] [ZEPPELIN-4726] Use entry.user & entry.password instead of user.entry and password.entry for credential injection (cherry picked from commit 4a8966d) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a refactoring PR which just use entry.user & entry.password instead of user.entry and password.entry for credential injection .
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: