[ZEPPELIN-4778]. Each getInterpreterContext call will load user credential file #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and password.entry for credential injection
asfgit
pushed a commit
that referenced
this pull request
May 15, 2020
…ntial file ### What is this PR for? This is a trivial PR which remove `loadCredentials` in `getUserCredentials`. It is not necessary and it would cause each `getInterpreterContext` call will load user credential file. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4778 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3770 from zjffdu/ZEPPELIN-4778 and squashes the following commits: 47cba07 [Jeff Zhang] [ZEPPELIN-4778] Use entry.user & entry.password instead of user.entry and password.entry for credential injection 8453460 [Jeff Zhang] [ZEPPELIN-4778]. Each getInterpreterContext call will load user credential file (cherry picked from commit f92327a) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is a trivial PR which remove
loadCredentialsingetUserCredentials. It is not necessary and it would cause eachgetInterpreterContextcall will load user credential file.What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: