Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented May 10, 2020

What is this PR for?

Flink doesn't work in cluster mode because we didn't use FlinkInterpreterLauncher in DockerInterpreterLauncher which is used in cluster mode. It is a straightforward change to just use FlinkInterpreterLauncher in DockerInterpreterLauncher

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in bb05460 May 10, 2020
asfgit pushed a commit that referenced this pull request May 10, 2020
…in cluster mode

### What is this PR for?

Flink doesn't work in cluster mode because we didn't use `FlinkInterpreterLauncher` in `DockerInterpreterLauncher` which is used in cluster mode. It is a straightforward change to just use `FlinkInterpreterLauncher` in `DockerInterpreterLauncher`

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4809

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <[email protected]>

Closes #3768 from zjffdu/ZEPPELIN-4809 and squashes the following commits:

1733a71 [Jeff Zhang] [ZEPPELIN-4809]. Zeppelin FlinkInterpreterLauncher not work in Zeppelin cluster mode

(cherry picked from commit bb05460)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants