Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented May 9, 2020

What is this PR for?

This PR actually solve 2 things in flink yarn mode.

  1. You don't need flink-hadoop-shaded jar when flink is not in yarn mode (before this PR, it is still needed even when it is not in yarn mode)
  2. Throw proper error message when hadoop jar is missing in yarn mode.

What type of PR is it?

[ Improvement ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? NO

Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in f63fdf6 May 10, 2020
asfgit pushed a commit that referenced this pull request May 10, 2020
… yarn mode for flink interpreter

### What is this PR for?
This PR actually solve 2 things in flink yarn mode.
1. You don't need flink-hadoop-shaded jar when flink is not in yarn mode (before this PR, it is still needed even when it is not in yarn mode)
2. Throw proper error message when hadoop jar is missing in yarn mode.

### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4806

### How should this be tested?
* CI pass

### Screenshots (if appropriate)
![image](https://user-images.githubusercontent.com/164491/81463335-843aa780-91eb-11ea-95ee-c8e475cdfa0e.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? NO

Author: Jeff Zhang <[email protected]>

Closes #3767 from zjffdu/ZEPPELIN-4806 and squashes the following commits:

5b75838 [Jeff Zhang] [ZEPPELIN-4806]. Throw proper exception when hadoop jar is missing in yarn mode for flink interpreter

(cherry picked from commit f63fdf6)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants