[ZEPPELIN-4763]. Use isolated interpreter for cron note job #3765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
reviewed
May 7, 2020
|
|
||
| private String user; | ||
| private String noteId; | ||
| private boolean inCronMode; |
Contributor
There was a problem hiding this comment.
You should add final, because you have no setter.
Contributor
Author
There was a problem hiding this comment.
Good catch，will fix it.
Reamer
reviewed
May 7, 2020
| } | ||
|
|
||
| private String getInterpreterGroupId(String user, String noteId) { | ||
| private static DateTimeFormatter dtf = DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm-ss"); |
Contributor
There was a problem hiding this comment.
Should also be an candidate for the final keyword.
Contributor
|
LGTM. Can you solve the merge conflict in |
zjffdu
force-pushed
the
ZEPPELIN-4763
branch
3 times, most recently
from
a5f2ec5 to
39147c3
Compare
asfgit
pushed a commit
that referenced
this pull request
May 8, 2020
### What is this PR for? This PR is to use isolated interpreter for cron note job. Cron job is for production job, so we should use dedicated interpreter for it instead of using shared interpreter with other notes or users. Currently interpreter binding mode is determined by note or users (scoped or isolated), This PR introduce `ExecutionContext` which include other factors (isCronMode) to determine how we create interpreters. ### What type of PR is it? [Feature] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4763 ### How should this be tested? * Unit test is updated, and manually tested ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3765 from zjffdu/ZEPPELIN-4763 and squashes the following commits: 39147c3 [Jeff Zhang] address comment 7bc690d [Jeff Zhang] [ZEPPELIN-4763]. Use isolated interpreter for cron note job (cherry picked from commit cd8a704) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is to use isolated interpreter for cron note job. Cron job is for production job, so we should use dedicated interpreter for it instead of using shared interpreter with other notes or users. Currently interpreter binding mode is determined by note or users (scoped or isolated), This PR introduce
ExecutionContextwhich include other factors (isCronMode) to determine how we create interpreters.What type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: