[ZEPPELIN-4797]. Enable multiple sql in jdbc interpreter by default #3764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reamer
reviewed
May 6, 2020
| } | ||
|
|
||
| List<String> sqlArray = sqlSplitter.splitSql(sql); | ||
| for (int i = 0; i < sqlArray.size(); i++) { |
alexott
reviewed
May 6, 2020
Comment on lines
691
to
693
| List<String> sqlArray = sqlSplitter.splitSql(sql); | ||
| for (int i = 0; i < sqlArray.size(); i++) { | ||
| String sqlToExecute = sqlArray.get(i); |
Contributor
There was a problem hiding this comment.
for-each loop would look nicer :-)
alexott
approved these changes
May 6, 2020
Contributor
alexott
left a comment
alexott
left a comment
There was a problem hiding this comment.
LGTM, with small comment
asfgit
pushed a commit
that referenced
this pull request
May 8, 2020
### What is this PR for? Before this PR, user have to set property `default.splitQueries` to enable multiple queries in one paragraph, this PR remove this property, this PR remove this property, and make multiple sql query in support by default. ### What type of PR is it? [Feature | Documentation] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4797 ### How should this be tested? * Unit test is updated ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <[email protected]> Closes #3764 from zjffdu/ZEPPELIN-4797 and squashes the following commits: 2323470 [Jeff Zhang] address comment fcb9e61 [Jeff Zhang] [ZEPPELIN-4797]. Enable multiple sql in jdbc interpreter by default (cherry picked from commit 1f6de95) Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Before this PR, user have to set property
default.splitQueriesto enable multiple queries in one paragraph, this PR remove this property, this PR remove this property, and make multiple sql query in support by default.What type of PR is it?
[Feature | Documentation]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: