[ZEPPELIN-4791] Fix Java version check on MacOS #3758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on MacOS, `[0-9]\+` doesn't work, so it was replaced with `[0-9][0-9]*`
asfgit
pushed a commit
that referenced
this pull request
May 3, 2020
### What is this PR for? on MacOS, `[0-9]\+` doesn't work, so it was replaced with `[0-9][0-9]*` ### What type of PR is it? Bug Fix ### What is the Jira issue? * ZEPPELIN-4791 ### How should this be tested? * Tested manually on Mac & Linux * https://travis-ci.org/github/alexott/zeppelin/builds/682342684 Author: Alex Ott <[email protected]> Closes #3758 from alexott/fix-java-version-check-on-mac and squashes the following commits: 9a77874 [Alex Ott] [HotFix] Fix Java version check on MacOS (cherry picked from commit 9a578a3) Signed-off-by: Alex Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
on MacOS,
[0-9]\+doesn't work, so it was replaced with[0-9][0-9]*What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?