[ZEPPELIN-4782] Correct K8s service usage in Zeppelin server #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Merge to master and branch-0.9 if no further comment. |
asfgit
pushed a commit
that referenced
this pull request
Apr 30, 2020
### What is this PR for? With this PR, we render the K8s-Service name into the Zeppelin interpreter start command for the initial connection. The K8s-Service name should be variable, because the name can vary from environment to environment. ### What type of PR is it? - Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4782 ### How should this be tested? * Travis-CI: https://travis-ci.org/github/Reamer/zeppelin/builds/680915013 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <[email protected]> Closes #3753 from Reamer/k8s_service and squashes the following commits: 74be24f [Philipp Dallig] Use K8s service to connect Zeppelin interpreter with Zeppelin server 7ecee5d [Philipp Dallig] Some cleanup 84e4e33 [Philipp Dallig] Add ".factorypath" to .gitignore it's created by eclipse (cherry picked from commit 4359193) Signed-off-by: Lee moon soo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
With this PR, we render the K8s-Service name into the Zeppelin interpreter start command for the initial connection.
The K8s-Service name should be variable, because the name can vary from environment to environment.
What type of PR is it?
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: