ZEPPELIN-371 : Import a notebook #374

prabhjyotsingh · 2015-10-28T11:29:49Z

Import a notebook by either an external URL or uploading a valid JSON.

felixcheung · 2015-10-29T18:52:41Z

could we add test for this?

prabhjyotsingh · 2015-10-30T05:30:47Z

Sure, I'll write a unit test case for this.

prabhjyotsingh · 2015-10-31T04:52:28Z

Added test case for the same as well.

CI fails in this PR. with following reason

[32;1mThe command "mvn package -Pbuild-distr -Phadoop-2.3 -Ppyspark -B" exited with 0.[0m
travis_time:start:088fd37b
�[0K$ ./testing/startSparkCluster.sh 1.4.0 2.3
SPARK_HOME is /home/travis/build/apache/incubator-zeppelin/spark-1.4.0-bin-hadoop2.3 


No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.

The build has been terminated

Leemoonsoo · 2015-11-02T14:23:31Z

Thanks @prabhjyotsingh for the nice feature. I manually tested and working well for me.
CI failing is fixed by #380. Could you try rebase this branch?

prabhjyotsingh · 2015-11-06T07:59:56Z

The build is failing with following error

    06:21:48,776  INFO org.apache.zeppelin.rest.AbstractTestRestApi:226 - Test Zeppelin terminated.
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.115 sec <<< FAILURE! - in org.apache.zeppelin.rest.ZeppelinRestApiTest
org.apache.zeppelin.rest.ZeppelinRestApiTest  Time elapsed: 4.115 sec  <<< ERROR!
java.lang.NullPointerException: null
at org.apache.zeppelin.rest.AbstractTestRestApi.startUp(AbstractTestRestApi.java:123)
at org.apache.zeppelin.rest.ZeppelinRestApiTest.init(ZeppelinRestApiTest.java:57)

Running org.apache.zeppelin.security.SecurityUtilsTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec - in org.apache.zeppelin.security.SecurityUtilsTest
Running org.apache.zeppelin.server.CorsFilterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec - in org.apache.zeppelin.server.CorsFilterTest
06:21:49,112  INFO org.apache.zeppelin.server.ZeppelinServer:112 - Shutting down Zeppelin Server ...
06:21:49,112  INFO org.apache.zeppelin.server.ZeppelinServer:112 - Shutting down Zeppelin Server ...
06:21:49,113  INFO org.apache.zeppelin.server.ZeppelinServer:118 - Bye
06:21:49,113  INFO org.apache.zeppelin.server.ZeppelinServer:118 - Bye

Results :

Tests in error:
ZeppelinSparkClusterTest.init:46->AbstractTestRestApi.startUp:123 Â» NullPointer
ZeppelinRestApiTest.init:57->AbstractTestRestApi.startUp:123 Â» NullPointer

Tests run: 16, Failures: 0, Errors: 2, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin ........................................... SUCCESS [ 10.558 s]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [01:19 min]
[INFO] Zeppelin: Zengine .................................. SUCCESS [  4.987 s]
[INFO] Zeppelin: Spark dependencies ....................... SUCCESS [ 32.026 s]
[INFO] Zeppelin: Spark .................................... SUCCESS [01:20 min]
[INFO] Zeppelin: Markdown interpreter ..................... SUCCESS [  0.700 s]
[INFO] Zeppelin: Angular interpreter ...................... SUCCESS [  0.279 s]
[INFO] Zeppelin: Shell interpreter ........................ SUCCESS [  0.356 s]
[INFO] Zeppelin: Hive interpreter ......................... SUCCESS [  2.433 s]
[INFO] Zeppelin: Apache Phoenix Interpreter ............... SUCCESS [ 10.156 s]
[INFO] Zeppelin: PostgreSQL interpreter ................... SUCCESS [  1.127 s]
[INFO] Zeppelin: Tajo interpreter ......................... SUCCESS [  1.565 s]
[INFO] Zeppelin: Flink .................................... SUCCESS [ 18.759 s]
[INFO] Zeppelin: Apache Ignite interpreter ................ SUCCESS [ 15.523 s]
[INFO] Zeppelin: Kylin interpreter ........................ SUCCESS [  0.678 s]
[INFO] Zeppelin: Lens interpreter ......................... SUCCESS [  3.232 s]
[INFO] Zeppelin: Cassandra ................................ SUCCESS [ 39.078 s]
[INFO] Zeppelin: web Application .......................... SUCCESS [ 37.655 s]
[INFO] Zeppelin: Server ................................... FAILURE [ 15.121 s]
[INFO] Zeppelin: Packaging distribution ................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:55 min
[INFO] Finished at: 2015-11-06T06:21:49+00:00
[INFO] Final Memory: 66M/362M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project zeppelin-server: There are test failures.
[ERROR]
[ERROR] Please refer to /home/travis/build/apache/incubator-zeppelin/zeppelin-server/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :zeppelin-server
travis_time:end:1b88a8e0:start=1446790550157092954,finish=1446790909997950807,duration=359840857853
�[0K
�[31;1mThe command "mvn verify -Pusing-packaged-distr -Phadoop-2.3 -Ppyspark -B" exited with 1.�[0m

My guess is, in AbstractTestRestApi:116
ZeppelinServer.notebook.getInterpreterFactory().get() is empty
any pointers what would have gone wrong ?

Leemoonsoo · 2015-11-08T01:41:51Z

I'm in the same CI test error in #341. Let me try to figure out.

Leemoonsoo · 2015-11-15T07:36:00Z

Please take a look NotebookServerTest. Extending AbstractTestRestApi helped me to make ci build passes in #341.

prabhjyotsingh · 2015-11-18T08:31:23Z

Thanks @Leemoonsoo, have made relevant changes.

now it fails for "ZeppelinIT.testAngularDisplay:173->createNewNote:306 » Timeout Timed out after"

-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.zeppelin.ZeppelinIT
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 22.224 sec <<< FAILURE! - in org.apache.zeppelin.ZeppelinIT
testAngularDisplay(org.apache.zeppelin.ZeppelinIT)  Time elapsed: 22.152 sec  <<< ERROR!
org.openqa.selenium.TimeoutException: Timed out after 10 seconds waiting for visibility of element located by By.id: noteNameModal
Build info: version: '2.44.0', revision: '76d78cf323ce037c5f92db6c1bba601c2ac43ad8', time: '2014-10-23 13:11:40'
System info: host: 'testing-worker-linux-docker-095ed8f0-3208-linux-3', ip: '172.17.12.223', os.name: 'Linux', os.arch: 'amd64', os.version: '3.13.0-40-generic', java.version: '1.7.0_76'
Session ID: e6ed0c8a-b983-40da-b950-09ead342ffe0
Driver info: org.openqa.selenium.firefox.FirefoxDriver
Capabilities [{platform=LINUX, acceptSslCerts=true, javascriptEnabled=true, cssSelectorsEnabled=true, databaseEnabled=true, browserName=firefox, handlesAlerts=true, nativeEvents=false, webStorageEnabled=true, rotatable=false, locationContextEnabled=true, applicationCacheEnabled=true, takesScreenshot=true, version=31.0}]
    at org.openqa.selenium.support.ui.WebDriverWait.timeoutException(WebDriverWait.java:79)
    at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:228)
    at org.apache.zeppelin.ZeppelinIT.createNewNote(ZeppelinIT.java:306)
    at org.apache.zeppelin.ZeppelinIT.testAngularDisplay(ZeppelinIT.java:173)


Results :

Tests in error:
  ZeppelinIT.testAngularDisplay:173->createNewNote:306 » Timeout Timed out after...

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

Trying to debug, will update once finished.

Leemoonsoo · 2015-11-21T02:50:33Z

zeppelin-web/src/index.html

Could you add license of ng-animation.css in zeppelin-distribution/src/bin_license/LICENSE file?
For example ngToast, https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-distribution/src/bin_license/LICENSE#L95

prabhjyotsingh · 2015-11-21T06:48:26Z

Thanks @Leemoonsoo while importing any external library I'll keep this in mind for next time.

Resolved build failure, ready for review.

Leemoonsoo · 2015-11-21T11:31:13Z

Working nicely, Looks good to me.

Leemoonsoo · 2015-11-23T11:39:10Z

Merge if there're no more discussions

rohitagarwal003 · 2015-11-24T03:32:02Z

zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java

Can we have uniform naming? All the other operations are called XYZ_NOTE. Let's follow that here as well.

Sure @mindprince, that make sense, did that. Thanks.

bzz · 2015-11-25T01:29:42Z

@prabhjyotsingh thank you, great feature.
Huge 👍 for having a tests!

It comes very handy with services like github or https://www.zeppelinhub.com/viewer

Update documentation for separate interpreter process apache#364

prabhjyotsingh closed this Oct 29, 2015

prabhjyotsingh reopened this Oct 29, 2015

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 3 times, most recently from 5e299c0 to 1978607 Compare October 29, 2015 06:14

prabhjyotsingh closed this Nov 3, 2015

prabhjyotsingh force-pushed the ZEPPELIN-371 branch from 18ed8c4 to fff175f Compare November 3, 2015 06:45

prabhjyotsingh reopened this Nov 3, 2015

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 7 times, most recently from 3c17892 to 980ee28 Compare November 6, 2015 07:51

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 2 times, most recently from 3d8c903 to 09c7280 Compare November 11, 2015 04:19

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 2 times, most recently from 64a6cfb to 40805cc Compare November 18, 2015 06:56

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 3 times, most recently from 83c2079 to 38f0811 Compare November 19, 2015 09:17

prabhjyotsingh force-pushed the ZEPPELIN-371 branch 2 times, most recently from 7160232 to b96ef1f Compare November 19, 2015 10:17

Leemoonsoo reviewed Nov 21, 2015
View reviewed changes

Import a notebook as JSON file or external URL

3b8816f

prabhjyotsingh force-pushed the ZEPPELIN-371 branch from 7e5b968 to 3b8816f Compare November 21, 2015 05:25

Fixing test case

246ae8b

rohitagarwal003 reviewed Nov 24, 2015
View reviewed changes

review changes; uniform naming: renaming IMPORT_NOTEBOOK to IMPORT_NOTE

35e1e02

asfgit closed this in fa5057c Nov 24, 2015

prabhjyotsingh deleted the ZEPPELIN-371 branch November 25, 2015 03:16

felixcheung mentioned this pull request Jan 11, 2016

Rest Apis to export/import with common code base #614

Closed

corneadoug mentioned this pull request Aug 10, 2016

Added ipfsnotebookrepo [ Zeppelin-683 ] #989

Closed

5 tasks

soralee pushed a commit to soralee/zeppelin that referenced this pull request Feb 9, 2017

Merge pull request apache#374 from NFLabs/gh-pages_update-interpreter

a81e781

Update documentation for separate interpreter process apache#364

ZEPPELIN-371 : Import a notebook #374

ZEPPELIN-371 : Import a notebook #374

Uh oh!

Conversation

prabhjyotsingh commented Oct 28, 2015

Uh oh!

felixcheung commented Oct 29, 2015

Uh oh!

prabhjyotsingh commented Oct 30, 2015

Uh oh!

prabhjyotsingh commented Oct 31, 2015

Uh oh!

Leemoonsoo commented Nov 2, 2015

Uh oh!

prabhjyotsingh commented Nov 6, 2015

Uh oh!

Leemoonsoo commented Nov 8, 2015

Uh oh!

Leemoonsoo commented Nov 15, 2015

Uh oh!

prabhjyotsingh commented Nov 18, 2015

Uh oh!

Leemoonsoo Nov 21, 2015

Choose a reason for hiding this comment

Uh oh!

prabhjyotsingh commented Nov 21, 2015

Uh oh!

Leemoonsoo commented Nov 21, 2015

Uh oh!

Leemoonsoo commented Nov 23, 2015

Uh oh!

rohitagarwal003 Nov 24, 2015

Choose a reason for hiding this comment

Uh oh!

prabhjyotsingh Nov 24, 2015

Choose a reason for hiding this comment

Uh oh!

bzz commented Nov 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants