Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Apr 8, 2020

What is this PR for?

Remove deprecation for SslContextFactory.
https://www.eclipse.org/jetty/javadoc/9.4.26.v20200117/org/eclipse/jetty/util/ssl/SslContextFactory.html#%3Cinit%3E()

Sorry for this little change. My IDE alerts me to this deprecation every time.

What type of PR is it?

  • Improvement

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor

zjffdu commented Apr 8, 2020

LGTM

@asfgit asfgit closed this in 5c3ce78 Apr 9, 2020
asfgit pushed a commit that referenced this pull request Apr 9, 2020
### What is this PR for?
Remove deprecation for SslContextFactory.
https://www.eclipse.org/jetty/javadoc/9.4.26.v20200117/org/eclipse/jetty/util/ssl/SslContextFactory.html#%3Cinit%3E()

Sorry for this little change. My IDE alerts me to this deprecation every time.
### What type of PR is it?
* Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4736

### How should this be tested?
* **Travis-CI**: https://travis-ci.org/github/Reamer/zeppelin/builds/672439814

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Philipp Dallig <[email protected]>

Closes #3727 from Reamer/direct_SslContextFactory_deprecation and squashes the following commits:

2fdb39d [Philipp Dallig] The direct use of SslContextFactory is deprecated

(cherry picked from commit 5c3ce78)
Signed-off-by: Alex Ott <[email protected]>
@Reamer Reamer deleted the direct_SslContextFactory_deprecation branch April 9, 2020 06:43
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Mar 2, 2022
### What is this PR for?
Remove deprecation for SslContextFactory.
https://www.eclipse.org/jetty/javadoc/9.4.26.v20200117/org/eclipse/jetty/util/ssl/SslContextFactory.html#%3Cinit%3E()

Sorry for this little change. My IDE alerts me to this deprecation every time.
### What type of PR is it?
* Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4736

### How should this be tested?
* **Travis-CI**: https://travis-ci.org/github/Reamer/zeppelin/builds/672439814

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Philipp Dallig <[email protected]>

Closes apache#3727 from Reamer/direct_SslContextFactory_deprecation and squashes the following commits:

2fdb39d [Philipp Dallig] The direct use of SslContextFactory is deprecated

Change-Id: I95acee33c9a630d04ebfb00a43c8b3222c14e0cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants