Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Apr 2, 2020

What is this PR for?

Fixed a regression in #3668.
With this fix zeppelin can save the notebook in HDFS.

What type of PR is it?

Regression Fix

What is the Jira issue?

How should this be tested?

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer Reamer force-pushed the notebook_dir_hdfs branch from dbdb6b1 to 0117609 Compare April 2, 2020 13:05
@zjffdu
Copy link
Contributor

zjffdu commented Apr 3, 2020

Thanks for the contribution @Reamer LGTM

@asfgit asfgit closed this in 6c10bb2 Apr 4, 2020
asfgit pushed a commit that referenced this pull request Apr 4, 2020
### What is this PR for?
Fixed a regression in #3668.
With this fix zeppelin can save the notebook in HDFS.

### What type of PR is it?
Regression Fix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4718

### How should this be tested?
* **Travis-Link**: https://travis-ci.org/github/Reamer/zeppelin/builds/670126594

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Philipp Dallig <[email protected]>

Closes #3713 from Reamer/notebook_dir_hdfs and squashes the following commits:

0117609 [Philipp Dallig] Check for filesystem with a scheme

(cherry picked from commit 6c10bb2)
Signed-off-by: Jeff Zhang <[email protected]>
@Reamer Reamer deleted the notebook_dir_hdfs branch April 6, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants