Skip to content

Conversation

@qiguoxiaosheng
Copy link
Contributor

@qiguoxiaosheng qiguoxiaosheng commented Apr 2, 2020

What is this PR for?

This PR is to fix a issue of connect presto via jdbc interpreter when more than one element needs to be removed from the jdbc properties. In this PR, I only change a method which iterate keys from jdbc properties. I tested it manully with presto-0.215.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4721

How should this be tested?

Compiles locally, no unit test performed.
There should has more than one element needs to be removed in the properties.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@alexott
Copy link
Contributor

alexott commented Apr 2, 2020

Can you file a JIRA, so we can put its number into changelog?

@qiguoxiaosheng qiguoxiaosheng changed the title Fix the ConcurrentModificationException occured when connect presto via JDBC generic interpreter [ZEPPELIN-4721]Fix the ConcurrentModificationException occured when connect presto via JDBC generic interpreter Apr 3, 2020
@zjffdu
Copy link
Contributor

zjffdu commented Apr 3, 2020

LGTM

@asfgit asfgit closed this in cb886d3 Apr 4, 2020
asfgit pushed a commit that referenced this pull request Apr 4, 2020
…onnect presto via JDBC generic interpreter

### What is this PR for?
This PR is to fix a issue of connect presto via jdbc interpreter when more than one element needs to be removed from the jdbc properties. In this PR, I only change a method which iterate keys from jdbc properties. I tested it manully with presto-0.215.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4721
### How should this be tested?
Compiles locally, no unit test performed.
There should has more than one element needs to be removed in the properties.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: qiguoxiaosheng <[email protected]>

Closes #3712 from qiguoxiaosheng/master and squashes the following commits:

1ecb53e [qiguoxiaosheng] modify the presto properties

(cherry picked from commit cb886d3)
Signed-off-by: Jeff Zhang <[email protected]>
@ahlag
Copy link

ahlag commented Jun 22, 2020

@alexott
I had the same issue. I was wondering if this PR is reflected in this link.
https://zeppelin.apache.org/download.html

@alexott
Copy link
Contributor

alexott commented Jun 23, 2020

@ahlag No, that PR was applied after preview1 was published... We need another preview or full release

@ahlag
Copy link

ahlag commented Jun 23, 2020

@alexott
Thank you for your prompt reply. Looking forward for the full release.

@gabriel-a
Copy link

Anyone knows if there is a work around for now without building from master? or any idea when the new preview2 or full release will be released?

@zjffdu
Copy link
Contributor

zjffdu commented Jun 29, 2020

@gabriel-a Preview2 will be released very soon, might be next week

@eljur
Copy link

eljur commented Mar 29, 2021

I just tried preview2, it throws NoClassDefFoundError for hive interpreter and does not fix presto one. Is it expected?

@zjffdu
Copy link
Contributor

zjffdu commented Mar 30, 2021

@eljur Your issue should not related with this PR, you can try 0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants