-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-4721]Fix the ConcurrentModificationException occured when connect presto via JDBC generic interpreter #3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can you file a JIRA, so we can put its number into changelog? |
|
LGTM |
…onnect presto via JDBC generic interpreter ### What is this PR for? This PR is to fix a issue of connect presto via jdbc interpreter when more than one element needs to be removed from the jdbc properties. In this PR, I only change a method which iterate keys from jdbc properties. I tested it manully with presto-0.215. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4721 ### How should this be tested? Compiles locally, no unit test performed. There should has more than one element needs to be removed in the properties. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: qiguoxiaosheng <[email protected]> Closes #3712 from qiguoxiaosheng/master and squashes the following commits: 1ecb53e [qiguoxiaosheng] modify the presto properties (cherry picked from commit cb886d3) Signed-off-by: Jeff Zhang <[email protected]>
|
@alexott |
|
@ahlag No, that PR was applied after preview1 was published... We need another preview or full release |
|
@alexott |
|
Anyone knows if there is a work around for now without building from master? or any idea when the new preview2 or full release will be released? |
|
@gabriel-a Preview2 will be released very soon, might be next week |
|
I just tried preview2, it throws NoClassDefFoundError for hive interpreter and does not fix presto one. Is it expected? |
|
@eljur Your issue should not related with this PR, you can try 0.9.0 |
What is this PR for?
This PR is to fix a issue of connect presto via jdbc interpreter when more than one element needs to be removed from the jdbc properties. In this PR, I only change a method which iterate keys from jdbc properties. I tested it manully with presto-0.215.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4721
How should this be tested?
Compiles locally, no unit test performed.
There should has more than one element needs to be removed in the properties.
Screenshots (if appropriate)
Questions: