Skip to content

Conversation

@alexott
Copy link
Contributor

@alexott alexott commented Mar 29, 2020

What is this PR for?

it adds missing license header to some files in the zeppelin-web-angular project

What type of PR is it?

Bug Fix

What is the Jira issue?

How should this be tested?

  • Doesn't require testing

@alexott
Copy link
Contributor Author

alexott commented Mar 29, 2020

@vthinkxie or @hsuanxyz can you review, so I can bump rat plugin version in ZEPPELIN-4700 ?

thank you

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zjffdu
Copy link
Contributor

zjffdu commented Mar 30, 2020

Thanks @alexott will merge it soon

@asfgit asfgit closed this in 5dcecad Mar 30, 2020
asfgit pushed a commit that referenced this pull request Mar 30, 2020
### What is this PR for?

it adds missing license header to some files in the zeppelin-web-angular project

### What type of PR is it?
Bug Fix

### What is the Jira issue?
* ZEPPELIN-4701

### How should this be tested?
* Doesn't require testing

Author: Alex Ott <[email protected]>

Closes #3703 from alexott/ZEPPELIN-4701 and squashes the following commits:

ece5870 [Alex Ott] [ZEPPELIN-4701] some zeppelin-web-angular files don't have license

(cherry picked from commit 5dcecad)
Signed-off-by: Jeff Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants