[ZEPPELIN-4378] porting Cassandra interpreter to new driver #3699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@doanduyhai can you help review it? |
Contributor
|
This is a massive update. I need to check it out and review it locally ! |
Contributor
Author
|
Yep, the new driver requires big refactoring...
I didn’t change much from functional point of view, except removing retry
policy...
|
Contributor
|
Looks good to me. Please solve the conflics before merging Thank for the fastastic job of migrating the driver version, it is not an easy task |
asfgit
pushed a commit
that referenced
this pull request
May 1, 2020
### What is this PR for? This PR refactors Cassandra interpreter to use new DataStax Java driver (4.x) that has new features & new architecture, that caused significant changes in the code base. But as result, we're getting: * We get supported version of the driver (3.x line will only receive critical bug fixes) * We get support for additional functionality of the DSE (DataStax Enterprise) - security, additional data types, etc. * Improvements in the load balancing, etc. ### What type of PR is it? Refactoring ### What is the Jira issue? * ZEPPELIN-4378 ### How should this be tested? * Travis CI build: https://travis-ci.org/github/alexott/zeppelin/builds/681878444 * Was tested manually in addition to the unit tests ### Questions: * Does the licenses files need update? Done, minor updates * Is there breaking changes for older versions? There are renames & deletion of the configuration properties, but this doesn't break existing setups. The only breaking change is removal of "standard" retry policies from syntax - but it was necessary to do, as they not shipped with driver anymore. * Does this needs documentation? Documentation was updated Author: Alex Ott <[email protected]> Closes #3699 from alexott/ZEPPELIN-4378 and squashes the following commits: 1c91453 [Alex Ott] [ZEPPELIN-4378] porting Cassandra interpreter to new driver (cherry picked from commit 5f6a5d5) Signed-off-by: Alex Ott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR refactors Cassandra interpreter to use new DataStax Java driver (4.x) that has new features & new architecture, that caused significant changes in the code base. But as result, we're getting:
What type of PR is it?
Refactoring
What is the Jira issue?
How should this be tested?
Questions: