[ZEPPELIN-4686] Update commons-lang to commons-lang3 #3691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for cleaning up this. @Reamer Could you paste the travis CI link ? |
Contributor
Author
|
Hi @zjffdu |
Contributor
|
Thanks @Reamer will merge it soon |
Contributor
Author
|
@zjffdu I had some questions in TODO. Can you please answer? |
asfgit
pushed a commit
that referenced
this pull request
Mar 20, 2020
### What is this PR for? I noticed that the Zeppelin project mixes "commons-lang" and "commons-lang3". I have (hopefully) changed all imports to `commons-lang3` I use `commons-lang3` 3.7, because this version was used in several submodules. ### What type of PR is it? Improvement ### Todos * [ ] - Is the replacement of `getFullStackTrace` to `getStackTrace` right? * [ ] - commons-lang isn't deleted from main `pom.xml`. Okay? ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4686 ### How should this be tested? * Unit-Tests withTravis CI https://travis-ci.org/github/Reamer/zeppelin/builds/663565663 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Philipp Dallig <[email protected]> Closes #3691 from Reamer/commons-lang3 and squashes the following commits: bf12fc0 [Philipp Dallig] Update to org.apache.commons commons-lang3 (cherry picked from commit f6f2bbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
I noticed that the Zeppelin project mixes "commons-lang" and "commons-lang3". I have (hopefully) changed all imports to
commons-lang3I use
commons-lang33.7, because this version was used in several submodules.What type of PR is it?
Improvement
Todos
getFullStackTracetogetStackTraceright?pom.xml. Okay?What is the Jira issue?
How should this be tested?
Questions: