Skip to content

Conversation

@Reamer
Copy link
Contributor

@Reamer Reamer commented Mar 13, 2020

What is this PR for?

Adding the library commons-configuration2 with is needed by Apache/shiro for string interpolation.
String interpolation is useful, when working with containers. You can interpolate several values, when starting the container.

Guide for String interpolation with shiro: https://stormpath.com/blog/string-interpolation-apache-shiro
Shiro-Commit with includes string interpolation: apache/shiro@af75fb5

What type of PR is it?

  • Feature

Todos

  • - Task

What is the Jira issue?

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@Reamer
Copy link
Contributor Author

Reamer commented Mar 13, 2020

@zjffdu
Copy link
Contributor

zjffdu commented Mar 14, 2020

Thanks @Reamer for the contribution, do you need to upgrade shiro as well ?

@Reamer
Copy link
Contributor Author

Reamer commented Mar 16, 2020

@zjffdu
An update of shiro is not required. Shiro version is 1.4.2, feature was added in 1.4.0.

@zjffdu
Copy link
Contributor

zjffdu commented Mar 16, 2020

Thanks, LGTM

@asfgit asfgit closed this in 233f39a Mar 17, 2020
@Reamer Reamer deleted the configuration_interpolation branch March 17, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants