[ZEPPELIN-4602] Added initial version of InfluxDB interpreter #3640

rhajek · 2020-02-11T15:41:26Z

What is this PR for?

The goal is to add support for querying InfluxDB 2.x using Flux language in Zeppelin notebook.

InfluxDB 2.0 (beta) docs
https://v2.docs.influxdata.com/v2.0/

Flux language docs:
https://docs.influxdata.com/flux/

What type of PR is it?

Feature

What is the Jira issue?

Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-4602

How should this be tested?

First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
Strongly recommended: add automated unit tests for any new or changed behavior
Outline any manual steps to test the PR here.

Screenshots (if appropriate)

linked in docs/interpreter/influxdb.md

zjffdu · 2020-02-13T03:13:46Z

influxdb/README.md

+## Build
+
+```
+mvn -pl zeppelin-interpreter,zeppelin-display,influxdb -DskipTests package


You can use mvn -pl influxdb -am -DskipTests package, influxdb depends on zeppelin-interpreter-shaded, so use -am would be easier. BTW, does influxdb interpreter depends on zeppelin-display ?

The interpreter does not depends on zeppelin-display, I just copied it from another interpreter. It is very basic interpreter now. In future we would like to add syntax highlighting and code complete.

zjffdu · 2020-02-13T03:14:23Z

influxdb/pom.xml

+        <dependency>
+            <groupId>com.influxdb</groupId>
+            <artifactId>influxdb-client-java</artifactId>
+            <version>${influxdb.client.version}</version>


What is the license of this dependency ? You need to put it in LICENCE file.

MIT, I added license to zeppelin-distribution/src/bin_license/LICENSE

I also added RxJava (Apache2 license) (used by InfluxDB client library)

zjffdu · 2020-02-13T03:14:46Z

influxdb/pom.xml

+        <dependency>
+            <groupId>com.squareup.okhttp3</groupId>
+            <artifactId>mockwebserver</artifactId>
+            <version>${dependency.okhttp3.version}</version>


Same licence issue as above

Apache 2, I added license to zeppelin-distribution/src/bin_license/LICENSE

zjffdu · 2020-02-13T03:15:09Z

influxdb/pom.xml

+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-checkstyle-plugin</artifactId>
+                <configuration>
+                    <skip>false</skip>


It's better to enable it. We are planning to enable it for other modules as well.

zjffdu · 2020-02-26T15:49:21Z

@rhajek Could you do a rebase and trigger the travis CI again ?

rhajek · 2020-02-26T16:30:12Z

It looks like there are some breaking changes, InfluxDBInterpreter.java:[28,39] cannot find symbol symbol: class BaseZeppelinContext, I will look on that.

zjffdu · 2020-02-29T00:19:15Z

@rhajek This is due to code refactoring which we just rename BaseZeppelinContext to ZeppelinContext

zjffdu · 2020-03-06T08:54:25Z

ping @rhajek Any update ？

rhajek · 2020-03-06T10:43:08Z

Oh sorry, Instead of rebase I merged 'apache:master' into my fork 'rhajek:master'.

Now this PR should be ready for merge.

timhallinflux · 2020-03-12T19:00:04Z

@zjffdu how does this look now? Good to go?

zjffdu · 2020-03-13T02:34:36Z

@rajeshkp Could you paste the travis CI link ?

rhajek · 2020-03-19T09:16:54Z

@rajeshkp Could you paste the travis CI link ?

Any updates ? Can I help with something ?

zjffdu · 2020-03-19T15:11:26Z

Sorry, I ping the wrong id, @rhajek Could you rebase this PR and paste the travis CI link ?

rhajek · 2020-03-20T10:03:20Z

Rebased, here is the travis link: https://travis-ci.org/github/rhajek/zeppelin?utm_medium=notification&utm_source=github_status

zjffdu · 2020-03-23T03:18:08Z

@rhajek There's several failure, may be due to flaky test. Could you rerun the build ?

rhajek · 2020-04-02T09:01:05Z

I rebased and manually tested InfluxDB interpreter in zeppelin UI. Also mvn -pl influxdb -am test is passing. Travis build is also ok.

alexott

LGTM...

@zjffdu what do you think?

docs/interpreter/influxdb.md

alexott · 2020-04-19T12:13:42Z

influxdb/src/main/java/org/apache/zeppelin/influxdb/InfluxDBInterpreter.java

+  static final String EMPTY_COLUMN_VALUE = "";
+
+  InfluxDBClient client;
+  QueryApi queryApi;


does it make sense to mark it as volatile ?

I'am not sure, I marked both variables as private and volatile.

…plugin configuration

…port for InfluxDB 1.8, interpreter code cleanup

rhajek · 2020-04-28T11:08:51Z

I rebased PR, Travis build also looks ok.

alexott · 2020-04-28T11:43:35Z

LGTM

zjffdu · 2020-04-28T13:38:32Z

LGTM

### What is this PR for? The goal is to add support for querying InfluxDB 2.x using Flux language in Zeppelin notebook. InfluxDB 2.0 (beta) docs https://v2.docs.influxdata.com/v2.0/ Flux language docs: https://docs.influxdata.com/flux/ ### What type of PR is it? Feature ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-4602 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) linked in docs/interpreter/influxdb.md Author: Robert Hajek <[email protected]> Closes #3640 from rhajek/master and squashes the following commits: 206848e [Robert Hajek] [ZEPPELIN-4602] updated influxdb client libraries to 1.7.0, added support for InfluxDB 1.8, interpreter code cleanup 34cd9ed [Robert Hajek] [ZEPPELIN-4602] BaseZeppelinContext replaced 8955205 [Robert Hajek] [ZEPPELIN-4602] Updated README.md, removed specific maven-checkstyle-plugin configuration 04b7e28 [Robert Hajek] [ZEPPELIN-4602] Added licences b6b9a48 [Robert Hajek] [ZEPPELIN-4602] Added initial version of InfluxDB interpreter (cherry picked from commit 94300b3) Signed-off-by: Alex Ott <[email protected]>

zjffdu reviewed Feb 13, 2020

View reviewed changes

rhajek force-pushed the master branch from 22c64b4 to 7e0984d Compare March 6, 2020 11:23

rhajek force-pushed the master branch from 7e0984d to 494d38c Compare March 20, 2020 10:01

rhajek force-pushed the master branch from 494d38c to 3bae7a4 Compare April 2, 2020 08:47

alexott approved these changes Apr 19, 2020

View reviewed changes

rhajek force-pushed the master branch from 3bae7a4 to 234e6fd Compare April 20, 2020 13:13

rhajek added 5 commits April 28, 2020 10:31

[ZEPPELIN-4602] Added initial version of InfluxDB interpreter

b6b9a48

[ZEPPELIN-4602] Added licences

04b7e28

[ZEPPELIN-4602] Updated README.md, removed specific maven-checkstyle-…

8955205

…plugin configuration

[ZEPPELIN-4602] BaseZeppelinContext replaced

34cd9ed

[ZEPPELIN-4602] updated influxdb client libraries to 1.7.0, added sup…

206848e

…port for InfluxDB 1.8, interpreter code cleanup

rhajek force-pushed the master branch from 234e6fd to 206848e Compare April 28, 2020 08:32

asfgit closed this in 94300b3 May 1, 2020

[ZEPPELIN-4602] Added initial version of InfluxDB interpreter #3640

[ZEPPELIN-4602] Added initial version of InfluxDB interpreter #3640

Uh oh!

Conversation

rhajek commented Feb 11, 2020

What is this PR for?

What type of PR is it?

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zjffdu commented Feb 26, 2020

Uh oh!

rhajek commented Feb 26, 2020

Uh oh!

zjffdu commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zjffdu commented Mar 6, 2020

Uh oh!

rhajek commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timhallinflux commented Mar 12, 2020

Uh oh!

zjffdu commented Mar 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhajek commented Mar 19, 2020

Uh oh!

zjffdu commented Mar 19, 2020

Uh oh!

rhajek commented Mar 20, 2020

Uh oh!

zjffdu commented Mar 23, 2020

Uh oh!

rhajek commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexott left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhajek commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexott commented Apr 28, 2020

Uh oh!

zjffdu commented Apr 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zjffdu commented Feb 29, 2020 •

edited

Loading

rhajek commented Mar 6, 2020 •

edited

Loading

zjffdu commented Mar 13, 2020 •

edited

Loading

rhajek commented Apr 2, 2020 •

edited

Loading

rhajek commented Apr 28, 2020 •

edited

Loading